Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1408973004: Separate sources that depend on printing into a different group. (Closed)

Created:
5 years, 1 month ago by slan
Modified:
5 years, 1 month ago
Reviewers:
halliwell, sky, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate sources that depend on printing into a different group. This new group is only included in the build when enable_basic_printing is true. Builds for which this variable is false (like Chromecast) will now pass gn check for the targets including these sources. BUG= Committed: https://crrev.com/a4d79bbaa49b30cad433f178758d49ed925c2ee3 Cr-Commit-Position: refs/heads/master@{#358219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/chrome_common.gypi View 3 chunks +15 lines, -11 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/all_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
slan
Scott, this is a structural change to separate sources with printing dependencies from chrome_common_sources. This ...
5 years, 1 month ago (2015-10-30 19:25:54 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-10-30 22:04:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408973004/1
5 years, 1 month ago (2015-10-30 22:06:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114478)
5 years, 1 month ago (2015-10-30 22:18:17 UTC) #7
slan
On 2015/10/30 22:18:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-04 00:02:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408973004/1
5 years, 1 month ago (2015-11-04 00:11:02 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 01:32:02 UTC) #12
slan
+dcheng@ for all_messages.h Daniel, could you please take a look? gn check does not know ...
5 years, 1 month ago (2015-11-04 01:38:17 UTC) #14
slan
On 2015/11/04 01:38:17, slan wrote: > +dcheng@ for all_messages.h > > Daniel, could you please ...
5 years, 1 month ago (2015-11-05 23:21:09 UTC) #15
dcheng
lgtm
5 years, 1 month ago (2015-11-05 23:25:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408973004/1
5 years, 1 month ago (2015-11-06 00:48:18 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 01:23:27 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 01:24:31 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4d79bbaa49b30cad433f178758d49ed925c2ee3
Cr-Commit-Position: refs/heads/master@{#358219}

Powered by Google App Engine
This is Rietveld 408576698