Clean up dependencies for disk_cache histogram_macros.h.

net/disk_cache/histogram_macros.h

Index: net/disk_cache/histogram_macros.h
diff --git a/net/disk_cache/histogram_macros.h b/net/disk_cache/histogram_macros.h
index 651bce96f2de8fbc2b0010a83c14f82ec383d9cb..a3ac330d76fb55d69b3a81d6fcfe49bd15dc8a69 100644
--- a/net/disk_cache/histogram_macros.h
+++ b/net/disk_cache/histogram_macros.h
@@ -84,11 +84,7 @@
 #define CACHE_HISTOGRAM_CACHE_ERROR(name, sample) \
     CACHE_HISTOGRAM_ENUMERATION(name, sample, 50)
 
-#ifdef NET_DISK_CACHE_BACKEND_IMPL_CC_
-#define BACKEND_OBJ this
-#else
-#define BACKEND_OBJ backend_
-#endif
+#define BACKEND_OBJ CACHE_HISTOGRAM_MACROS_BACKEND_IMPL_OBJ

[rvargas (doing something else), 2014/02/11 02:17:15]

Why not go all the way and let the caller define BACKEND_OBJ (aka, remove this
line)? The fact that the caller is including this file means that BACKEND_OBJ
gets defined anyway for that compilation unit.

The only weird case could be the user from chrome/net, but this file was never
intended to be used outside of disk_cache to start with, and it is rather
unfortunate that it was.

[gavinp, 2014/02/11 16:12:45]

Done. Went with BLOCKFILE_BACKEND_IMPL_OBJ, since this is blockfile cache
specific.

[rvargas (doing something else), 2014/02/11 19:41:48]

Lots of redundancy on that name IMO (BLOCKFILE is implied given that this will
live under a folder with that name (and not being a public api), and there is no
way to have an object of something that is not the implementation of a backend).
But the difference is small enough to not matter much.

 
 // Generates a UMA histogram of the given type, generating the proper name for
 // it (asking backend_->HistogramName), and adding the provided sample.