Clean up dependencies for disk_cache histogram_macros.h.

chrome/browser/net/http_pipelining_compatibility_client.cc

Index: chrome/browser/net/http_pipelining_compatibility_client.cc
diff --git a/chrome/browser/net/http_pipelining_compatibility_client.cc b/chrome/browser/net/http_pipelining_compatibility_client.cc
index 4ccafbbdb2875f8d05b3c57c04fa8ce065fcc7f8..2ac129fa718637a04aee11ccfc6817bf9661199c 100644
--- a/chrome/browser/net/http_pipelining_compatibility_client.cc
+++ b/chrome/browser/net/http_pipelining_compatibility_client.cc
@@ -15,7 +15,6 @@
 #include "net/base/load_flags.h"
 #include "net/base/network_change_notifier.h"
 #include "net/base/request_priority.h"
-#include "net/disk_cache/histogram_macros.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_response_headers.h"
@@ -25,6 +24,13 @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 
+
+// This is included because the CACHE_HISTOGRAM_* macros allow dynamic metric
+// names.
+// TODO(gavinp,rvargas): Clean up this dependency by moving the needed

[rvargas (doing something else), 2014/02/11 02:17:15]

TODOs reference the person that added the line, not the person who is in charge
of fixing it (aka, only one person).

[gavinp, 2014/02/11 16:12:45]

Done.

However, do note that
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#TODO_Comments
says it's for whoever can provide context, which I thought was both of us. About
1% of TODOs in our codebase have commas right now.

+// functionality into base/.
+#include "net/disk_cache/histogram_macros.h"
+
 namespace chrome_browser_net {
 
 static const int kCanaryRequestId = 999;
@@ -364,8 +370,6 @@ void HttpPipeliningCompatibilityClient::OnCanaryFinished(
 
 void HttpPipeliningCompatibilityClient::OnRequestFinished(
     int request_id, internal::PipelineTestRequest::Status status) {
-  // The CACHE_HISTOGRAM_* macros are used, because they allow dynamic metric
-  // names.
   CACHE_HISTOGRAM_ENUMERATION(GetMetricName(request_id, "Status"),
                               status,
                               internal::PipelineTestRequest::STATUS_MAX);