Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/net/http_pipelining_compatibility_client.cc

Issue 140893013: Clean up dependencies for disk_cache histogram_macros.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix fat finger Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/disk_cache/backend_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/http_pipelining_compatibility_client.cc
diff --git a/chrome/browser/net/http_pipelining_compatibility_client.cc b/chrome/browser/net/http_pipelining_compatibility_client.cc
index 4ccafbbdb2875f8d05b3c57c04fa8ce065fcc7f8..4b36dabefc05d8b2a88b021b9b3c5d64abbefa62 100644
--- a/chrome/browser/net/http_pipelining_compatibility_client.cc
+++ b/chrome/browser/net/http_pipelining_compatibility_client.cc
@@ -366,6 +366,8 @@ void HttpPipeliningCompatibilityClient::OnRequestFinished(
int request_id, internal::PipelineTestRequest::Status status) {
// The CACHE_HISTOGRAM_* macros are used, because they allow dynamic metric
// names.
+ // TODO(gavinp): Clean up this dependency by moving the needed functionality
+ // into base/.
CACHE_HISTOGRAM_ENUMERATION(GetMetricName(request_id, "Status"),
status,
internal::PipelineTestRequest::STATUS_MAX);
« no previous file with comments | « no previous file | net/disk_cache/backend_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698