Issue 140893010: A64: Relax assert in register copy ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140893010: A64: Relax assert in register copy ctor. (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

A64: Relax assert in register copy ctor. It's ok to copy a "NoReg"-type regsiter BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19162

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/a64/assembler-a64.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Rodolph Perfetta (ARM)

LGTM. nit: CPURegiter has a private method IsValidOrNone, how about making it public and reuse ...

6 years, 10 months ago (2014-02-06 15:22:31 UTC) #2

jochen (gone - plz use gerrit)

6 years, 10 months ago (2014-02-06 15:32:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19162 (presubmit successful).