Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 140893010: A64: Relax assert in register copy ctor. (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Relax assert in register copy ctor. It's ok to copy a "NoReg"-type regsiter BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/a64/assembler-a64.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-06 15:16:56 UTC) #1
Rodolph Perfetta (ARM)
LGTM. nit: CPURegiter has a private method IsValidOrNone, how about making it public and reuse ...
6 years, 10 months ago (2014-02-06 15:22:31 UTC) #2
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-06 15:32:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698