Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 140893006: [Files.app] Show dot files in the Drive volume. (Closed)

Created:
6 years, 10 months ago by yoshiki
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Show dot files in the Drive volume. Previously, the dot files were hidden by default and could be toggled. This patch makes them visible only on Drive folder, since there are some temporary file in the Download directory and they should be hidden. BUG=196539 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248153

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/directory_contents.js View 3 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 6 chunks +39 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoshiki
hirono, PTAL. Thanks.
6 years, 10 months ago (2014-01-30 07:07:00 UTC) #1
hirono
lgtm with a nit! https://codereview.chromium.org/140893006/diff/80001/chrome/browser/resources/file_manager/foreground/js/file_manager.js File chrome/browser/resources/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/140893006/diff/80001/chrome/browser/resources/file_manager/foreground/js/file_manager.js#newcode1337 chrome/browser/resources/file_manager/foreground/js/file_manager.js:1337: return (entry.name.substr(0, 1) !== '.'); ...
6 years, 10 months ago (2014-01-30 08:07:01 UTC) #2
yoshiki
Thanks!
6 years, 10 months ago (2014-01-31 05:37:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/140893006/100001
6 years, 10 months ago (2014-01-31 05:38:06 UTC) #4
commit-bot: I haz the power
Change committed as 248153
6 years, 10 months ago (2014-01-31 08:23:57 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 08:23:58 UTC) #6
Avi (use Gerrit)
I am reverting this. The ChromeOS ASAN bots are rather unhappy, for example: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20... http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20... ...
6 years, 10 months ago (2014-01-31 17:01:31 UTC) #7
Avi (use Gerrit)
6 years, 10 months ago (2014-01-31 19:09:25 UTC) #8
Message was sent while issue was closed.
On 2014/01/31 17:01:31, Avi wrote:
> I am reverting this.
> 
> The ChromeOS ASAN bots are rather unhappy, for example:
> 
>
http://build.chromium.org/p/chromium.memory/builders/Linux%2520Chromium%2520O....
>
http://build.chromium.org/p/chromium.memory/builders/Linux%2520Chromium%2520O....
>
http://build.chromium.org/p/chromium.memory/builders/Linux%2520Chromium%2520O....
> 
> They are failing (crashing?) on FileManagerBrowserTest. The failures have:
> 
> [30190:30190:0131/015143:2459751373:INFO:CONSOLE(3322)] "Uncaught TypeError:
> Cannot call method 'toURL' of undefined", source:
>
chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/media/mediaplayer_scripts.js
> (3322)
> 
> Reverted with 248208.

Reverting this change did indeed make the bots go green; fix this change before
re-committing it.

Powered by Google App Engine
This is Rietveld 408576698