Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 140893002: Adding slightly clearer separation between SW and EmbeddedWorker (still incomplete) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added TODO to filter messages on the browser side Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/embedded_worker_instance.h" 5 #include "content/browser/service_worker/embedded_worker_instance.h"
6 6
7 #include "content/browser/service_worker/embedded_worker_registry.h" 7 #include "content/browser/service_worker/embedded_worker_registry.h"
8 #include "content/common/service_worker/embedded_worker_messages.h" 8 #include "content/common/service_worker/embedded_worker_messages.h"
9 #include "ipc/ipc_message.h"
9 #include "url/gurl.h" 10 #include "url/gurl.h"
10 11
11 namespace content { 12 namespace content {
12 13
13 EmbeddedWorkerInstance::~EmbeddedWorkerInstance() { 14 EmbeddedWorkerInstance::~EmbeddedWorkerInstance() {
14 registry_->RemoveWorker(process_id_, embedded_worker_id_); 15 registry_->RemoveWorker(process_id_, embedded_worker_id_);
15 } 16 }
16 17
17 bool EmbeddedWorkerInstance::Start( 18 bool EmbeddedWorkerInstance::Start(
18 int64 service_worker_version_id, 19 int64 service_worker_version_id,
(...skipping 15 matching lines...) Expand all
34 } 35 }
35 36
36 bool EmbeddedWorkerInstance::Stop() { 37 bool EmbeddedWorkerInstance::Stop() {
37 DCHECK(status_ == STARTING || status_ == RUNNING); 38 DCHECK(status_ == STARTING || status_ == RUNNING);
38 const bool success = registry_->StopWorker(process_id_, embedded_worker_id_); 39 const bool success = registry_->StopWorker(process_id_, embedded_worker_id_);
39 if (success) 40 if (success)
40 status_ = STOPPING; 41 status_ = STOPPING;
41 return success; 42 return success;
42 } 43 }
43 44
44 bool EmbeddedWorkerInstance::SendFetchRequest( 45 bool EmbeddedWorkerInstance::SendMessage(const IPC::Message& message) {
45 const ServiceWorkerFetchRequest& request) {
46 DCHECK(status_ == RUNNING); 46 DCHECK(status_ == RUNNING);
47 // TODO: Refine this code, the code around FetchEvent is currently very
48 // rough, mainly just for a placeholder for now.
49 return registry_->Send(process_id_, 47 return registry_->Send(process_id_,
50 new EmbeddedWorkerContextMsg_FetchEvent( 48 new EmbeddedWorkerContextMsg_SendMessageToWorker(
51 thread_id_, embedded_worker_id_, request)); 49 thread_id_, embedded_worker_id_, message));
52 } 50 }
53 51
54 void EmbeddedWorkerInstance::AddProcessReference(int process_id) { 52 void EmbeddedWorkerInstance::AddProcessReference(int process_id) {
55 ProcessRefMap::iterator found = process_refs_.find(process_id); 53 ProcessRefMap::iterator found = process_refs_.find(process_id);
56 if (found == process_refs_.end()) 54 if (found == process_refs_.end())
57 found = process_refs_.insert(std::make_pair(process_id, 0)).first; 55 found = process_refs_.insert(std::make_pair(process_id, 0)).first;
58 ++found->second; 56 ++found->second;
59 } 57 }
60 58
61 void EmbeddedWorkerInstance::ReleaseProcessReference(int process_id) { 59 void EmbeddedWorkerInstance::ReleaseProcessReference(int process_id) {
(...skipping 26 matching lines...) Expand all
88 FOR_EACH_OBSERVER(Observer, observer_list_, OnStarted()); 86 FOR_EACH_OBSERVER(Observer, observer_list_, OnStarted());
89 } 87 }
90 88
91 void EmbeddedWorkerInstance::OnStopped() { 89 void EmbeddedWorkerInstance::OnStopped() {
92 status_ = STOPPED; 90 status_ = STOPPED;
93 process_id_ = -1; 91 process_id_ = -1;
94 thread_id_ = -1; 92 thread_id_ = -1;
95 FOR_EACH_OBSERVER(Observer, observer_list_, OnStopped()); 93 FOR_EACH_OBSERVER(Observer, observer_list_, OnStopped());
96 } 94 }
97 95
96 void EmbeddedWorkerInstance::OnMessageReceived(const IPC::Message& message) {
97 FOR_EACH_OBSERVER(Observer, observer_list_, OnMessageReceived(message));
98 }
99
98 void EmbeddedWorkerInstance::AddObserver(Observer* observer) { 100 void EmbeddedWorkerInstance::AddObserver(Observer* observer) {
99 observer_list_.AddObserver(observer); 101 observer_list_.AddObserver(observer);
100 } 102 }
101 103
102 void EmbeddedWorkerInstance::RemoveObserver(Observer* observer) { 104 void EmbeddedWorkerInstance::RemoveObserver(Observer* observer) {
103 observer_list_.RemoveObserver(observer); 105 observer_list_.RemoveObserver(observer);
104 } 106 }
105 107
106 bool EmbeddedWorkerInstance::ChooseProcess() { 108 bool EmbeddedWorkerInstance::ChooseProcess() {
107 DCHECK_EQ(-1, process_id_); 109 DCHECK_EQ(-1, process_id_);
108 // Naive implementation; chooses a process which has the biggest number of 110 // Naive implementation; chooses a process which has the biggest number of
109 // associated providers (so that hopefully likely live longer). 111 // associated providers (so that hopefully likely live longer).
110 ProcessRefMap::iterator max_ref_iter = process_refs_.end(); 112 ProcessRefMap::iterator max_ref_iter = process_refs_.end();
111 for (ProcessRefMap::iterator iter = process_refs_.begin(); 113 for (ProcessRefMap::iterator iter = process_refs_.begin();
112 iter != process_refs_.end(); ++iter) { 114 iter != process_refs_.end(); ++iter) {
113 if (max_ref_iter == process_refs_.end() || 115 if (max_ref_iter == process_refs_.end() ||
114 max_ref_iter->second < iter->second) 116 max_ref_iter->second < iter->second)
115 max_ref_iter = iter; 117 max_ref_iter = iter;
116 } 118 }
117 if (max_ref_iter == process_refs_.end()) 119 if (max_ref_iter == process_refs_.end())
118 return false; 120 return false;
119 process_id_ = max_ref_iter->first; 121 process_id_ = max_ref_iter->first;
120 return true; 122 return true;
121 } 123 }
122 124
123 } // namespace content 125 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/browser/service_worker/embedded_worker_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698