Change long press behavior when touch text selection is enabled:

Source/WebCore/page/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 2458 matching lines @@
     PlatformMouseEvent fakeMouseUp(adjustedPoint, gestureEvent.globalPosition(),
         LeftButton, PlatformEvent::MouseReleased, tapCount,
         gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), gestureEvent.timestamp());
     defaultPrevented |= handleMouseReleaseEvent(fakeMouseUp);
 
     return defaultPrevented;
 }
 
 bool EventHandler::handleGestureLongPress(const PlatformGestureEvent& gestureEvent)
 {
+    IntPoint adjustedPoint = gestureEvent.position();
+#if ENABLE(TOUCH_ADJUSTMENT)
+    adjustGesturePosition(gestureEvent, adjustedPoint);
+#endif
+    PlatformMouseEvent mouseDown(adjustedPoint, gestureEvent.globalPosition(), LeftButton, PlatformEvent::MousePressed, 1,
+        gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), gestureEvent.timestamp());
+    HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::DisallowShadowContent);

[hayato, 2013/04/17 04:51:03]

Could we remove DisallowShadowContent from this HitTest?
I don't see any reason to disallow shadow content here.
MouseEvent should happen in the shadow tree.

[varunjain, 2013/04/17 17:45:36]

I am not sure but wouldnt DisallowShadowContent stop the hit test from
descending into shadow dom? If that is indeed correct, I think we should keep
it. There is no reason this hit test should go into shadow dom.

+    MouseEventWithHitTestResults mev = prepareMouseEvent(request, mouseDown);
+    RefPtr<Frame> subframe = subframeForHitTestResult(mev);
+    if (subframe && subframe->eventHandler()->handleGestureLongPress(gestureEvent))
+        return true;
+
+    m_didLongPressInvokeContextMenu = true;
     if (m_frame->settings() && m_frame->settings()->touchDragDropEnabled() && m_frame->view()) {
-        IntPoint adjustedPoint = gestureEvent.position();
-#if ENABLE(TOUCH_ADJUSTMENT)
-        adjustGesturePosition(gestureEvent, adjustedPoint);
-#endif
         PlatformMouseEvent mouseDragEvent(adjustedPoint, gestureEvent.globalPosition(), LeftButton, PlatformEvent::MouseMoved, 1,
             gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), WTF::currentTime());
         HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::DisallowShadowContent);
         MouseEventWithHitTestResults mev = prepareMouseEvent(request, mouseDragEvent);
         m_didStartDrag = false;
-        RefPtr<Frame> subframe = subframeForHitTestResult(mev);
-        if (subframe && subframe->eventHandler()->handleGestureLongPress(gestureEvent))
-            return true;
         m_mouseDownMayStartDrag = true;
         dragState().m_dragSrc = 0;
         m_mouseDownPos = m_frame->view()->windowToContents(mouseDragEvent.position());
         handleDrag(mev, DontCheckDragHysteresis);
-        if (m_didStartDrag)
+        if (m_didStartDrag) {
+            m_didLongPressInvokeContextMenu = false;
             return true;
+        }
     }
-    return handleGestureForTextSelectionOrContextMenu(gestureEvent);
-}
-
-bool EventHandler::handleGestureLongTap(const PlatformGestureEvent& gestureEvent)
-{
-#if ENABLE(CONTEXT_MENUS) && !OS(ANDROID)
-    if (!m_didLongPressInvokeContextMenu)
-        return sendContextMenuEventForGesture(gestureEvent);
+    bool shouldLongPressSelectWord = m_frame->settings() && m_frame->settings()->touchEditingEnabled();

[hayato, 2013/04/17 04:51:03]

Line 2507 to 2510 could be merged into #IF .. #ELSE ... #ENDIF block.
e.g.
#if OS(ANDROID)
  bool shouldLongPressSelectWord = true
#else
  bool shouldLongPressSelectWord = ...
#endif

[varunjain, 2013/04/17 17:45:36]

Done.

+#if OS(ANDROID)
+    shouldLongPressSelectWord = true;
 #endif
-    return false;
-}
-
-bool EventHandler::handleGestureForTextSelectionOrContextMenu(const PlatformGestureEvent& gestureEvent)
-{
-#if OS(ANDROID)
-    IntPoint hitTestPoint = m_frame->view()->windowToContents(gestureEvent.position());
-    HitTestResult result = hitTestResultAtPoint(hitTestPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
-    Node* innerNode = result.targetNode();
-    if (!result.isLiveLink() && innerNode && (innerNode->isContentEditable() || innerNode->isTextNode())) {
-        selectClosestWordFromHitTestResult(result, DontAppendTrailingWhitespace);
-        if (m_frame->selection()->isRange())
-            return true;
+    if (shouldLongPressSelectWord) {
+      IntPoint hitTestPoint = m_frame->view()->windowToContents(gestureEvent.position());
+      HitTestResult result = hitTestResultAtPoint(hitTestPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
+      Node* innerNode = result.targetNode();
+      if (!result.isLiveLink() && innerNode && (innerNode->isContentEditable() || innerNode->isTextNode())) {
+          selectClosestWordFromHitTestResult(result, DontAppendTrailingWhitespace);
+          if (m_frame->selection()->isRange())
+              return true;
+      }
     }
-#endif
 #if ENABLE(CONTEXT_MENUS)
-    m_didLongPressInvokeContextMenu = (gestureEvent.type() == PlatformEvent::GestureLongPress);
     return sendContextMenuEventForGesture(gestureEvent);
 #else
     return false;
 #endif
 }
 
+bool EventHandler::handleGestureLongTap(const PlatformGestureEvent& gestureEvent)

[hayato, 2013/04/17 04:51:03]

It's optional, but looks like we can share some of code between
handleGestureLongPress and handleGestureLongTap.

[varunjain, 2013/04/17 17:45:36]

Done.

+{
+    IntPoint adjustedPoint = gestureEvent.position();
+#if ENABLE(TOUCH_ADJUSTMENT)
+    adjustGesturePosition(gestureEvent, adjustedPoint);
+#endif
+    PlatformMouseEvent mouseDown(adjustedPoint, gestureEvent.globalPosition(), LeftButton, PlatformEvent::MousePressed, 1,
+        gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), gestureEvent.timestamp());
+    HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::DisallowShadowContent);
+    MouseEventWithHitTestResults mev = prepareMouseEvent(request, mouseDown);
+    RefPtr<Frame> subframe = subframeForHitTestResult(mev);
+    if (subframe && subframe->eventHandler()->handleGestureLongTap(gestureEvent))
+        return true;
+#if ENABLE(CONTEXT_MENUS) && !OS(ANDROID)
+    if (!m_didLongPressInvokeContextMenu)
+        return sendContextMenuEventForGesture(gestureEvent);
+    m_didLongPressInvokeContextMenu = true;
+#endif
+    return false;
+}
+
 bool EventHandler::handleGestureTwoFingerTap(const PlatformGestureEvent& gestureEvent)
 {
-    return handleGestureForTextSelectionOrContextMenu(gestureEvent);
+    return sendContextMenuEventForGesture(gestureEvent);
 }
 
 bool EventHandler::passGestureEventToWidget(const PlatformGestureEvent& gestureEvent, Widget* widget)
 {
     if (!widget)
         return false;
 
     if (!widget->isFrameView())
         return false;
 
@@ skipping 1375 matching lines @@
 #endif
 
 void EventHandler::setLastKnownMousePosition(const PlatformMouseEvent& event)
 {
     m_mousePositionIsUnknown = false;
     m_lastKnownMousePosition = event.position();
     m_lastKnownMouseGlobalPosition = event.globalPosition();
 }
 
 } // namespace WebCore