Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14089003: Remove storageBlockingPolicy (Closed)

Created:
7 years, 8 months ago by pilgrim_google
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, darin (slow to review)
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Repatch to ToT #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -862 lines) Patch
D LayoutTests/http/tests/security/cross-origin-appcache.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-appcache-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-indexeddb.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-indexeddb-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-local-storage.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-local-storage-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-session-storage.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-session-storage-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-shared-worker.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-shared-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-websql.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-websql-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-indexeddb.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-indexeddb-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-websql.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-websql-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/http/tests/security/resources/document-for-cross-origin-worker-websql.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-appcache-blocked.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-appcache-blocked-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-document-domain-storage-allowed.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-document-domain-storage-allowed-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-shared-worker-blocked.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-shared-worker-blocked-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-storage-blocked.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-storage-blocked-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-websql-blocked.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-local-storage.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-local-storage-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-shared-worker.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-shared-worker-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-websql.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-local-storage-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-shared-worker.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-websql.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M Source/WebCore/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/page/Page.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/WebCore/page/SecurityOrigin.h View 3 chunks +0 lines, -9 lines 0 comments Download
M Source/WebCore/page/SecurityOrigin.cpp View 4 chunks +1 line, -17 lines 0 comments Download
M Source/WebCore/page/Settings.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/plugins/PluginViewBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/testing/InternalSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/testing/InternalSettings.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/WebCore/testing/InternalSettings.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pilgrim_google
7 years, 8 months ago (2013-04-11 21:41:30 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/14089003/diff/1/Source/WebCore/page/SecurityOrigin.cpp File Source/WebCore/page/SecurityOrigin.cpp (right): https://codereview.chromium.org/14089003/diff/1/Source/WebCore/page/SecurityOrigin.cpp#newcode375 Source/WebCore/page/SecurityOrigin.cpp:375: bool SecurityOrigin::canAccessStorage(const SecurityOrigin* topOrigin) const In the next ...
7 years, 8 months ago (2013-04-11 21:47:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/14089003/10001
7 years, 8 months ago (2013-04-12 14:18:06 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 15:11:44 UTC) #4
Message was sent while issue was closed. 
Change committed as 148284

Powered by Google App Engine
This is Rietveld 408576698