Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1408893002: X87: [turbofan] Fix calls to computed code objects. (Closed)

Created:
5 years, 2 months ago by shiyu.zhang
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fix calls to computed code objects. port 924b0ecf8556ef75d3dff960b04c2a6318345c56 (r31057). contributed by zhengxing.li@intel.com original commit message: BUG= Committed: https://crrev.com/07449ddc8661d624426612377d2b4a89d8d2c518 Cr-Commit-Position: refs/heads/master@{#31321}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
chunyang.dai
On 2015/10/16 03:01:25, shiyu.zhang wrote: > mailto:shiyu.zhang@intel.com changed reviewers: > + mailto:chunyang.dai@intel.com LGTM
5 years, 2 months ago (2015-10-16 03:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408893002/1
5 years, 2 months ago (2015-10-16 03:07:55 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-16 03:07:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408893002/1
5 years, 2 months ago (2015-10-16 03:08:48 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-16 03:08:50 UTC) #11
Weiliang
lgtm
5 years, 2 months ago (2015-10-16 03:29:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408893002/1
5 years, 2 months ago (2015-10-16 03:29:47 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 03:50:29 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 03:50:57 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07449ddc8661d624426612377d2b4a89d8d2c518
Cr-Commit-Position: refs/heads/master@{#31321}

Powered by Google App Engine
This is Rietveld 408576698