Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 1408873002: Ignore InputMsg IPCs if RenderView is in swapped out state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Alex's review. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index 0cea2ed130aa2bfdeee417b27e28568519b477f1..103709908d6f9ea610d1d11e9d9a862eb8b8c9c0 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -20,6 +20,7 @@
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/browser/webui/web_ui_impl.h"
#include "content/common/content_constants_internal.h"
+#include "content/common/input_messages.h"
#include "content/common/site_isolation_policy.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
@@ -2115,4 +2116,51 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
ResourceDispatcherHost::Get()->SetDelegate(nullptr);
}
+// Tests that InputMsg type IPCs are ignored by swapped out RenderViews. It
+// uses the SetFocus IPC, as RenderView has a CHECK to ensure that condition
+// never happens.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
+ InputMsgToSwappedOutRVHIsIgnored) {
+ StartEmbeddedServer();
+ EXPECT_TRUE(NavigateToURL(
+ shell(), embedded_test_server()->GetURL("a.com", "/title1.html")));
+
+ // Open a popup to navigate cross-process.
+ Shell* new_shell =
+ OpenPopup(shell()->web_contents(), GURL(url::kAboutBlankURL), "foo");
+ EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
+ new_shell->web_contents()->GetSiteInstance());
+
+ // Keep a pointer to the RenderViewHost, which will be in swapped out
+ // state after navigating cross-process. This is how this test is causing
+ // a swapped out RenderView to receive InputMsg IPC message.
+ WebContentsImpl* new_web_contents =
+ static_cast<WebContentsImpl*>(new_shell->web_contents());
+ FrameTreeNode* new_root = new_web_contents->GetFrameTree()->root();
+ RenderViewHostImpl* rvh = new_web_contents->GetRenderViewHost();
+
+ // Navigate the popup to a different site, so the |rvh| is swapped out.
+ EXPECT_TRUE(NavigateToURL(
+ new_shell, embedded_test_server()->GetURL("b.com", "/title2.html")));
+ EXPECT_NE(shell()->web_contents()->GetSiteInstance(),
+ new_shell->web_contents()->GetSiteInstance());
+ EXPECT_EQ(rvh, new_root->render_manager()->GetSwappedOutRenderViewHost(
+ shell()->web_contents()->GetSiteInstance()));
+
+ // Setup a process observer to ensure there is no crash and send the IPC
+ // message.
+ RenderProcessHostWatcher watcher(
+ rvh->GetProcess(), RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
+ rvh->Send(new InputMsg_SetFocus(rvh->GetRoutingID(), true));
+
+ // The test must wait for a process to exit, but if the IPC message is
+ // properly ignored, there will be no crash. Therefore, navigate the
+ // original window to the same site as the popup, which will just exit the
+ // process cleanly.
+ EXPECT_TRUE(NavigateToURL(
+ shell(), embedded_test_server()->GetURL("b.com", "/title3.html")));
+ watcher.Wait();
+ EXPECT_TRUE(watcher.did_exit_normally());
+}
+
} // namespace content
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698