Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408863011: infra: Remove all references to the OSX 10.10 SDK. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years, 1 month ago
Reviewers:
Sergey Berezin, Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

infra: Remove all references to the OSX 10.10 SDK. By default, all build targets already use the 10.10 SDK, so there's no need to specify it. This CL should not have any functional effects. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297427

Patch Set 1 #

Patch Set 2 : Comments from thakis. #

Patch Set 3 : Remove another newly added 10_10 sdk reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -345 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_angle.py View 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_mac.py View 6 chunks +6 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py View 5 chunks +0 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_angle_Mac10_8_Tests__ANGLE_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_angle_Mac10_8_Tests__dbg___ANGLE_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_angle_Mac_Builder__ANGLE_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_angle_Mac_Builder__dbg___ANGLE_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_8_Tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_6.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_7.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_7__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_8.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_9.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_dbg_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_rel_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_mac_angle_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_summary.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_swarming_error.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.py View 1 1 chunk +0 lines, -11 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_fyi_link_against_10_10.json View 1 1 chunk +0 lines, -231 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
erikchen
thakis: Please review.
5 years, 1 month ago (2015-11-02 20:10:15 UTC) #2
Nico
Can this go away too https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipes/gpu/build_and_upload.py&l=55 ? Other than that: Hooray, and lgtm!
5 years, 1 month ago (2015-11-02 20:12:28 UTC) #3
erikchen
On 2015/11/02 20:12:28, Nico wrote: > Can this go away too > https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipes/gpu/build_and_upload.py&l=55 > ? ...
5 years, 1 month ago (2015-11-02 20:29:09 UTC) #4
erikchen
sergeyberezin: Please review scripts/slave/recipe_modules/chromium_tests.
5 years, 1 month ago (2015-11-02 20:32:09 UTC) #6
Sergey Berezin
lgtm
5 years, 1 month ago (2015-11-02 21:52:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408863011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408863011/40001
5 years, 1 month ago (2015-11-02 21:55:32 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 22:07:21 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297427

Powered by Google App Engine
This is Rietveld 408576698