chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java - Issue 1408853002: [Tabbed mode] Restore tabs even if TabState is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java

Issue 1408853002: [Tabbed mode] Restore tabs even if TabState is missing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java

index b33cae9c71768b1e78bd6b6e32144e93c08588fc..db9f1bb69299002653a8f12b3c6d84a884a1e6f9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java

@@ -81,8 +81,8 @@ public class DocumentMigrationHelper {

private int mSelectedTabId = Tab.INVALID_TAB_ID;

@Override

- public void onDetailsRead(int index, int id, String url, boolean isStandardActiveIndex,

- boolean isIncognitoActiveIndex) {

+ public void onDetailsRead(int index, int id, String url, Boolean isIncognito,

+ boolean isStandardActiveIndex, boolean isIncognitoActiveIndex) {

TabIdManager.getInstance().incrementIdCounterTo(id + 1);

if (!isStandardActiveIndex) return;

// If the current tab read is the active standard tab, set the last used