third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp - Issue 1408833006: EmailInputType::convertEmailAddressToASCII() should not try to convert non-email addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp

Issue 1408833006: EmailInputType::convertEmailAddressToASCII() should not try to convert non-email addresses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use isValidEmailAddress() instead of ad-hoc check Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp b/third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp

index 2e1740a09d9c99a2cb2c45c19ae346847ef79334..5c1a6569f6d8995f624f49802c3ad1558ed96479 100644

--- a/third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp

+++ b/third_party/WebKit/Source/core/html/forms/EmailInputTypeTest.cpp

@@ -29,6 +29,14 @@ void expectToFail(const String& source)

TEST(EmailInputTypeTest, ConvertEmailAddressToASCII)

{

+ // U+043C U+043E U+0439 . U+0434 U+043E U+043C U+0435 U+043D

+ expectToFail(String::fromUTF8("user@\xD0\xBC\xD0\xBE\xD0\xB9.\xD0\xB4\xD0\xBE\xD0\xBC\xD0\xB5\xD0\xBD@"));

+ expectToFail(String::fromUTF8("user@\xD0\xBC\xD0\xBE\xD0\xB9. \xD0\xB4\xD0\xBE\xD0\xBC\xD0\xB5\xD0\xBD"));

+ expectToFail(String::fromUTF8("user@\xD0\xBC\xD0\xBE\xD0\xB9.\t\xD0\xB4\xD0\xBE\xD0\xBC\xD0\xB5\xD0\xBD"));

+TEST(EmailInputTypeTest, ConvertEmailAddressToASCIIUTS46)

// http://unicode.org/reports/tr46/#Table_IDNA_Comparisons

// U+00E0

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/EmailInputType.cpp ('k') | no next file » | no next file with comments »