Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 140883012: Removing "#if 0" style comments (Closed)

Created:
6 years, 11 months ago by David Abrahams
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changing comments in test to use // rather than preprocessor directives as per https://code.google.com/p/chromium/issues/detail?id=334276 BUG=334276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247614

Patch Set 1 #

Patch Set 2 : Issue 334276 Fixing comment style #

Patch Set 3 : Delete dead lines #

Patch Set 4 : Removed orphan #endif #

Total comments: 1

Patch Set 5 : Remove empty #if branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -42 lines) Patch
M chrome/browser/sync/sync_global_error_unittest.cc View 1 2 3 4 4 chunks +5 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
David Abrahams
Decided to just address issue 334276 myself rather than triaging since it's unreachable code anyway. ...
6 years, 11 months ago (2014-01-23 01:24:19 UTC) #1
pval...(no longer on Chromium)
+rsimha to provide some advice w/ context Also, please shorten CL description to 72 lines ...
6 years, 11 months ago (2014-01-23 02:19:08 UTC) #2
Raghu Simha
Looks like the code was #if 0'd a long time back, with https://chromiumcodereview.appspot.com/10692195/diff/63013/chrome/browser/sync/sync_global_error_unittest.cc. It's unlikely ...
6 years, 11 months ago (2014-01-24 00:17:07 UTC) #3
David Abrahams
On 2014/01/24 00:17:07, Raghu Simha wrote: > Looks like the code was #if 0'd a ...
6 years, 11 months ago (2014-01-28 01:34:51 UTC) #4
Raghu Simha
https://codereview.chromium.org/140883012/diff/80001/chrome/browser/sync/sync_global_error_unittest.cc File chrome/browser/sync/sync_global_error_unittest.cc (right): https://codereview.chromium.org/140883012/diff/80001/chrome/browser/sync/sync_global_error_unittest.cc#newcode107 chrome/browser/sync/sync_global_error_unittest.cc:107: // http://crbug.com/134675 Technically, this is dead code too, and ...
6 years, 11 months ago (2014-01-28 01:40:03 UTC) #5
David Abrahams
On 2014/01/28 01:40:03, Raghu Simha wrote: > Technically, this is dead code too, and ought ...
6 years, 11 months ago (2014-01-28 01:58:26 UTC) #6
Raghu Simha
LGTM!
6 years, 11 months ago (2014-01-28 02:34:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/resetswitch@chromium.org/140883012/90001
6 years, 10 months ago (2014-01-28 19:07:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:01:40 UTC) #9
Message was sent while issue was closed.
Change committed as 247614

Powered by Google App Engine
This is Rietveld 408576698