Issue 140883005: win: taskkill mspdbsrv.exe before updating toolchain

Issue 140883005: win: taskkill mspdbsrv.exe before updating toolchain (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
Dirk Pranke, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

win: taskkill mspdbsrv.exe before updating toolchain It stays resident, so try to tidy up, otherwise removing the old directory will fail. TBR=maruel@chromium.org BUG=323300 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245324

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
		win_toolchain/get_toolchain_if_necessary.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/140883005/1

6 years, 11 months ago (2014-01-16 21:04:16 UTC) #4

commit-bot: I haz the power

Presubmit check for 140883005-1 failed and returned exit status 1. Running presubmit commit checks ...

6 years, 11 months ago (2014-01-16 21:06:05 UTC) #5

Presubmit check for 140883005-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/checkout_test.py (7.81s) failed
EEEE...................
======================================================================
ERROR: testAll (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
382, in set_up_git
    self.check_port_is_free(self.git_port)
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
427, in check_port_is_free
    assert False, '%d shouldn\'t be bound' % port
AssertionError: 20000 shouldn't be bound

======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
362, in set_up_git
    assert self.git_pid_file == None
AssertionError

======================================================================
ERROR: testMove (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
362, in set_up_git
    assert self.git_pid_file == None
AssertionError

======================================================================
ERROR: testProcess (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
362, in set_up_git
    assert self.git_pid_file == None
AssertionError

----------------------------------------------------------------------
Ran 23 tests in 7.563s

FAILED (errors=4)


Presubmit checks took 105.9s to calculate.

scottmg

On 2014/01/16 21:06:05, I haz the power (commit-bot) wrote: > Presubmit check for 140883005-1 failed ...

6 years, 11 months ago (2014-01-16 21:06:52 UTC) #6

On 2014/01/16 21:06:05, I haz the power (commit-bot) wrote:
> Presubmit check for 140883005-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Checking out rietveld...
> Running save-description-on-failure.sh
> Running push-basic.sh
> Running upstream.sh
> Running submit-from-new-dir.sh
> Running abandon.sh
> Running submodule-merge-test.sh
> Running upload-local-tracking-branch.sh
> Running hooks.sh
> Running post-dcommit-hook-test.sh
> Running upload-stale.sh
> Running patch.sh
> Running basic.sh
> 
> ** Presubmit Messages **
> --tbr was specified, skipping OWNERS check
> 
> ** Presubmit ERRORS **
> tests/checkout_test.py (7.81s) failed
> EEEE...................
> ======================================================================
> ERROR: testAll (__main__.GitCheckout)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tests/checkout_test.py", line 347, in setUp
>     self.enabled = self.FAKE_REPOS.set_up_git()
>   File
> "/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line
> 382, in set_up_git
>     self.check_port_is_free(self.git_port)
>   File
> "/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line
> 427, in check_port_is_free
>     assert False, '%d shouldn\'t be bound' % port
> AssertionError: 20000 shouldn't be bound
> 
> ======================================================================
> ERROR: testException (__main__.GitCheckout)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tests/checkout_test.py", line 347, in setUp
>     self.enabled = self.FAKE_REPOS.set_up_git()
>   File
> "/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line
> 362, in set_up_git
>     assert self.git_pid_file == None
> AssertionError
> 
> ======================================================================
> ERROR: testMove (__main__.GitCheckout)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tests/checkout_test.py", line 347, in setUp
>     self.enabled = self.FAKE_REPOS.set_up_git()
>   File
> "/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line
> 362, in set_up_git
>     assert self.git_pid_file == None
> AssertionError
> 
> ======================================================================
> ERROR: testProcess (__main__.GitCheckout)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tests/checkout_test.py", line 347, in setUp
>     self.enabled = self.FAKE_REPOS.set_up_git()
>   File
> "/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line
> 362, in set_up_git
>     assert self.git_pid_file == None
> AssertionError
> 
> ----------------------------------------------------------------------
> Ran 23 tests in 7.563s
> 
> FAILED (errors=4)
> 
> 
> Presubmit checks took 105.9s to calculate.

YA RIGHT

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/140883005/1

6 years, 11 months ago (2014-01-16 21:06:58 UTC) #7

Message was sent while issue was closed.

Change committed as 245324

Expand Messages | Collapse Messages