Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 140883005: win: taskkill mspdbsrv.exe before updating toolchain (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

win: taskkill mspdbsrv.exe before updating toolchain It stays resident, so try to tidy up, otherwise removing the old directory will fail. TBR=maruel@chromium.org BUG=323300 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
win_toolchain/get_toolchain_if_necessary.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
6 years, 11 months ago (2014-01-16 21:01:10 UTC) #1
scottmg
(oops, fixed Subject)
6 years, 11 months ago (2014-01-16 21:01:33 UTC) #2
Dirk Pranke
lgtm
6 years, 11 months ago (2014-01-16 21:03:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/140883005/1
6 years, 11 months ago (2014-01-16 21:04:16 UTC) #4
commit-bot: I haz the power
Presubmit check for 140883005-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-16 21:06:05 UTC) #5
scottmg
On 2014/01/16 21:06:05, I haz the power (commit-bot) wrote: > Presubmit check for 140883005-1 failed ...
6 years, 11 months ago (2014-01-16 21:06:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/140883005/1
6 years, 11 months ago (2014-01-16 21:06:58 UTC) #7
M-A Ruel
Windows. lgtm
6 years, 11 months ago (2014-01-16 21:08:47 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 21:12:27 UTC) #9
Message was sent while issue was closed.
Change committed as 245324

Powered by Google App Engine
This is Rietveld 408576698