Issue 140883003: stringBuilder in CSSFilterValue::customCSSText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140883003: stringBuilder in CSSFilterValue::customCSSText (Closed)

Created:
6 years, 11 months ago by maheshkk

Modified:
6 years, 10 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

In CSSFilterValue::customCSSText we could replace string building with StringBuilder for a better peformance. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165982

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
		Source/core/css/CSSFilterValue.cpp	View		2 chunks	+16 lines, -14 lines	0 comments	Download

Total messages: 8 (0 generated)

maheshkk

Saw slightly better browsermark score when compared with this fix. What you think about this?

6 years, 11 months ago (2014-01-16 19:42:50 UTC) #1

maheshkk

On 2014/01/16 19:42:50, maheshkk wrote: > Saw slightly better browsermark score when compared with this ...

6 years, 11 months ago (2014-01-16 19:58:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/140883003/1

6 years, 10 months ago (2014-01-28 21:39:37 UTC) #6

commit-bot: I haz the power

6 years, 10 months ago (2014-01-29 00:35:40 UTC) #8

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.