Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: net/base/ip_address_number.h

Issue 1408803010: Add IPAddress class as a replacement for the IPAddressNumber typedef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove duplicated implementations Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_address_number.h
diff --git a/net/base/ip_address_number.h b/net/base/ip_address_number.h
index b1058758d9d1f3b91c7d4dfb264369b5b54a17ea..bce3c980fde53255649b964793304c9c4c120122 100644
--- a/net/base/ip_address_number.h
+++ b/net/base/ip_address_number.h
@@ -19,6 +19,10 @@ namespace net {
// network byte ordering.
//
// IPv4 addresses will have length 4, whereas IPv6 address will have length 16.
+//
+// TODO(Martijnc): Remove the IPAddressNumber typedef. New code should use
+// IPAddress instead and existing code should be switched over.
+// https://crbug.com/496258
typedef std::vector<unsigned char>
IPAddressNumber; // This is also duplicated in net_util.h
typedef std::vector<IPAddressNumber> IPAddressList;

Powered by Google App Engine
This is Rietveld 408576698