Add IPAddress class as a replacement for the IPAddressNumber typedef.

net/base/ip_address.cc

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/base/ip_address.h"
+
+#include "net/base/ip_address_number.h"
+#include "url/gurl.h"
+#include "url/url_canon_ip.h"
+
+namespace net {
+
+namespace {
+const unsigned char kIPv4MappedPrefix[] = {0, 0, 0, 0, 0,    0,

[eroman, 2015/12/01 23:00:39]

Can remove this per the later comment.

[martijnc, 2015/12/02 21:28:07]

Done.

+                                           0, 0, 0, 0, 0xFF, 0xFF};
+}
+
+const size_t IPAddress::kIPv4AddressSize = 4;
+const size_t IPAddress::kIPv6AddressSize = 16;
+
+IPAddress::IPAddress() {}
+
+IPAddress::~IPAddress() {}
+
+IPAddress::IPAddress(const uint8_t* address, size_t address_len)
+    : ip_address_(std::vector<uint8_t>(address, address + address_len)) {}

[eroman, 2015/12/01 23:00:40]

std::vector<> is not needed here. How about just:

   : ip_address_(address, address + address_len)

[martijnc, 2015/12/02 21:28:06]

Done.

+
+bool IPAddress::IsIPv4() const {
+  return ip_address_.size() == kIPv4AddressSize;
+}
+
+bool IPAddress::IsIPv6() const {
+  return ip_address_.size() == kIPv6AddressSize;
+}
+
+// Don't compare IPv4 and IPv6 addresses (they have different range

[eroman, 2015/12/01 23:00:39]

Remove this comment (it is duplicated from ip_address_number.cc).

Since we are just calling that other implementation no need for it.

[martijnc, 2015/12/02 21:28:07]

Done.

+// reservations). Keep separate reservation arrays for each IP type, and
+// consolidate adjacent reserved ranges within a reservation array when
+// possible.
+// Sources for info:
+// www.iana.org/assignments/ipv4-address-space/ipv4-address-space.xhtml
+// www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xhtml
+// They're formatted here with the prefix as the last element. For example:
+// 10.0.0.0/8 becomes 10,0,0,0,8 and fec0::/10 becomes 0xfe,0xc0,0,0,0...,10.
+bool IPAddress::IsReserved() const {
+  return IsIPAddressReserved(ip_address_);
+}
+
+bool IPAddress::IsIPv4Mapped() const {

[eroman, 2015/12/01 23:00:40]

Sorry I should have been more explicit about this in the earlier patchset, but I
don't want this change to duplicate existing code in ip_address_number.cc

There will be a transition period where functionality will have entry points in
both places (Method in IPAddress, and free-floating function in
ip_address_number.h). During this time we don't want to have duplicated
implementations, but instead just "forward" the implementation.

In the future when the callers have been converted to using IPAddress and the
free-floating function is no longer being used, we can move it to this .cc file.

For this CL we can simply do:

  return IsIpv4Mapped(ip_address_);

[martijnc, 2015/12/02 21:28:07]

Done.

+  if (!IsIPv6())
+    return false;
+  return std::equal(ip_address_.begin(),
+                    ip_address_.begin() + arraysize(kIPv4MappedPrefix),
+                    kIPv4MappedPrefix);
+}
+
+std::string IPAddress::ToString() const {

[eroman, 2015/12/01 23:00:40]

Same thing here:

  return IPAddressToString(ip_address_);

[martijnc, 2015/12/02 21:28:07]

Done.

+  std::string str;
+  url::StdStringCanonOutput output(&str);
+
+  if (IsIPv4()) {
+    url::AppendIPv4Address(&ip_address_.front(), &output);
+  } else if (IsIPv6()) {
+    url::AppendIPv6Address(&ip_address_.front(), &output);
+  } else {
+    CHECK(false) << "Invalid IP address with length: " << ip_address_.size();
+  }
+
+  output.Complete();
+  return str;
+}
+
+// static
+bool IPAddress::FromIPLiteral(const base::StringPiece& ip_literal,

[eroman, 2015/12/01 23:00:40]

Same here:

std::vector<uint8_t> number;
if (!ParseIPLiteralToNumber(ip_literal, &number))
  return false;

std::swap(number, ip_address->ip_address_);
return true;

[martijnc, 2015/12/02 21:28:07]

Done.

+                              IPAddress* ip_address) {
+  std::vector<unsigned char> ip;
+
+  // |ip_literal| could be either a IPv4 or an IPv6 literal. If it contains
+  // a colon however, it must be an IPv6 address.
+  if (ip_literal.find(':') != base::StringPiece::npos) {
+    // GURL expects IPv6 hostnames to be surrounded with brackets.
+    std::string host_brackets = "[";
+    ip_literal.AppendToString(&host_brackets);
+    host_brackets.push_back(']');
+    url::Component host_comp(0, host_brackets.size());
+
+    // Try parsing the hostname as an IPv6 literal.
+    ip.resize(16);  // 128 bits.
+    if (!url::IPv6AddressToNumber(host_brackets.data(), host_comp, &(ip)[0]))
+      return false;
+    std::swap(ip, ip_address->ip_address_);
+    return true;
+  }
+
+  // Otherwise the string is an IPv4 address.
+  ip.resize(4);  // 32 bits.
+  url::Component host_comp(0, ip_literal.size());
+  int num_components;
+  url::CanonHostInfo::Family family = url::IPv4AddressToNumber(
+      ip_literal.data(), host_comp, &(ip)[0], &num_components);
+  if (family != url::CanonHostInfo::IPV4)
+    return false;
+  std::swap(ip, ip_address->ip_address_);
+  return true;
+}
+
+bool IPAddress::operator==(const IPAddress& that) const {
+  return ip_address_ == that.ip_address_;
+}
+
+bool IPAddress::operator<(const IPAddress& that) const {
+  // Sort IPv4 before IPv6.
+  if (ip_address_.size() != that.ip_address_.size()) {
+    return ip_address_.size() < that.ip_address_.size();
+  }
+
+  return ip_address_ < that.ip_address_;
+}
+
+}  // namespace net