Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1408803003: Enforce queries' new availability semantics. (Closed)

Created:
5 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, blink-reviews, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce queries' new availability semantics. Queries' results do not become available until control returns to the browser's main loop. Tested for all query types with new and modified tests in the WebGL 2.0 conformance suite. BUG=539727 Committed: https://crrev.com/787e71aee905d6bb1660097197d3e49cf91331b0 Cr-Commit-Position: refs/heads/master@{#354557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.h View 3 chunks +20 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp View 4 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks. I decided not to try to share code between WebGLTimerQueryEXT and WebGLQuery. ...
5 years, 2 months ago (2015-10-16 02:06:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408803003/1
5 years, 2 months ago (2015-10-16 02:06:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 03:13:37 UTC) #6
bajones
lgtm
5 years, 2 months ago (2015-10-16 18:18:18 UTC) #7
bajones
lgtm
5 years, 2 months ago (2015-10-16 18:18:19 UTC) #8
Zhenyao Mo
LGTM
5 years, 2 months ago (2015-10-16 18:25:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408803003/1
5 years, 2 months ago (2015-10-16 18:35:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 18:44:20 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 18:45:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/787e71aee905d6bb1660097197d3e49cf91331b0
Cr-Commit-Position: refs/heads/master@{#354557}

Powered by Google App Engine
This is Rietveld 408576698