Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1408793008: ipc: Make MessageAttachment inherit from RefCountedThreadSafe. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Make MessageAttachment inherit from RefCountedThreadSafe. Previously, it inherited from RefCounted, which was wrong, since it's possible for multiple threads to simultaneously have scoped_ptr references to a single MessageAttachment. BUG=535711 Committed: https://crrev.com/fa705362defe8ba29f7ba93570ea5cb8a5df0981 Cr-Commit-Position: refs/heads/master@{#357216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ipc/ipc_message_attachment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mach_port_attachment_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
tsepez: Please review.
5 years, 1 month ago (2015-10-30 21:25:17 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-10-30 21:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408793008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408793008/1
5 years, 1 month ago (2015-10-30 21:39:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 23:16:36 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 23:17:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa705362defe8ba29f7ba93570ea5cb8a5df0981
Cr-Commit-Position: refs/heads/master@{#357216}

Powered by Google App Engine
This is Rietveld 408576698