Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1408783005: Change default build and test architecture to x64. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
Cutch, srdjan, siva
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change default build and test architecture to x64. Precompilation isn't supported on IA32 so local testing misses it. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/783ed2470b13b1bb8406dd64434a44fc5798ca06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-16 17:53:16 UTC) #2
srdjan
LGTM also because precompilation tests do not run on ia32
5 years, 2 months ago (2015-10-16 17:56:26 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-16 17:59:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
783ed2470b13b1bb8406dd64434a44fc5798ca06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698