Issue 1408783004: dart2js cps: Support --trust-primitives and --trust-type-annotations.

Issue 1408783004: dart2js cps: Support --trust-primitives and --trust-type-annotations. (Closed)

Created:
5 years, 2 months ago by asgerf

Modified:
5 years, 1 month ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Support --trust-primitives and --trust-type-annotations. Values assigned to a local variable are assumed to satisfy the type annotation if --trust-type-annotations is given. Bounds checks are omitted if --trust-primitives is given. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/646a0b277fab91f4ddf44f41f701a53c3d7959f6

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -24 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1	10 chunks	+33 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/insert_refinements.dart	View	1	4 chunks	+38 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/remove_refinements.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1 2 3	7 chunks	+14 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

sra1

Inserting casts that always succeed feels a bit hacky. The SSA backend inserts refinements to ...

5 years, 2 months ago (2015-10-21 00:09:45 UTC) #3

asgerf

PTAL. Now using refinement nodes, and using trust-primitives for rewriting operators where the operands might ...

5 years, 2 months ago (2015-10-21 14:33:47 UTC) #4

asgerf

5 years, 1 month ago (2015-11-02 10:26:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
646a0b277fab91f4ddf44f41f701a53c3d7959f6 (presubmit successful).