Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1408743006: Rework task model graphing to work on buildbots. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework task model graphing to work on buildbots. This CL reworks the task model grapher (formerly at pkg/analyzer/tool/task_dependency_graph.dart, now at pkg/analyzer/tool/task_dependency_graph/generate.dart) so that it works similarly to the code generation in the analysis server. Namely, the output file is stored in source control (pkg/analyzer/tool/task_dependency_graph/tasks.dot), and a test run by the buildbots verifies that it is up to date. If it is not, the test outputs the command necessary to update it. This carries the benefit that: - Anyone with access to an installation of graphviz can generate the task model graph easily from its .dot file. - Any time a change occurs that affects task model dependencies, a test failure will prompt us that we need to generate a new .dot file. - If a change ever occurs that breaks the ability of the task dependency grapher to produce the graph, a test failure will prompt us. The downside is that when making a change that affects task model dependencies, it is now necessary to re-run the script pkg/analyzer/tool/task_dependency_graph/generate.dart to avoid a test failure. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c5f4af4df6c252f55fb2c08897e5d795c4ee92a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -330 lines) Patch
D pkg/analyzer/tool/task_dependency_graph.dart View 1 chunk +0 lines, -297 lines 0 comments Download
A pkg/analyzer/tool/task_dependency_graph/check_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + pkg/analyzer/tool/task_dependency_graph/generate.dart View 8 chunks +81 lines, -33 lines 0 comments Download
A pkg/analyzer/tool/task_dependency_graph/tasks.dot View 1 chunk +245 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paul Berry
5 years, 2 months ago (2015-10-16 16:23:04 UTC) #2
Brian Wilkerson
> The downside is that when making a change that affects task model > dependencies, ...
5 years, 2 months ago (2015-10-16 16:32:30 UTC) #3
scheglov
LGTM Having a shell script would be perfect :-)
5 years, 2 months ago (2015-10-16 17:26:24 UTC) #4
Paul Berry
On 2015/10/16 17:26:24, scheglov wrote: > LGTM > > Having a shell script would be ...
5 years, 2 months ago (2015-10-19 16:24:08 UTC) #5
Paul Berry
5 years, 2 months ago (2015-10-19 16:24:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5f4af4df6c252f55fb2c08897e5d795c4ee92a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698