Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3742)

Unified Diff: chrome/browser/sync/sessions/page_revisit_broadcaster.cc

Issue 1408643002: [Sync] Componentize synced_tab_delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test broken by rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/page_revisit_broadcaster.cc
diff --git a/chrome/browser/sync/sessions/page_revisit_broadcaster.cc b/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
index 05a9846c9cc6396a6e4989af5831b705fd28c302..ded3778d9aa88a77aceb25d12e283859793cd9c4 100644
--- a/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
+++ b/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
@@ -9,7 +9,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/metrics/field_trial.h"
-#include "chrome/browser/sync/glue/synced_session_util.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/history/core/browser/history_service.h"
@@ -17,6 +16,7 @@
#include "components/sync_sessions/revisit/bookmarks_page_revisit_observer.h"
#include "components/sync_sessions/revisit/sessions_page_revisit_observer.h"
#include "components/sync_sessions/revisit/typed_url_page_revisit_observer.h"
+#include "components/sync_sessions/sync_sessions_client.h"
namespace browser_sync {
@@ -45,8 +45,10 @@ class SessionsSyncManagerWrapper
PageRevisitBroadcaster::PageRevisitBroadcaster(
SessionsSyncManager* sessions,
+ sync_sessions::SyncSessionsClient* sessions_client,
history::HistoryService* history,
- bookmarks::BookmarkModel* bookmarks) {
+ bookmarks::BookmarkModel* bookmarks)
+ : sessions_client_(sessions_client) {
const std::string group_name =
base::FieldTrialList::FindFullName("PageRevisitInstrumentation");
bool shouldInstrument = group_name == "Enabled";
@@ -69,7 +71,7 @@ PageRevisitBroadcaster::~PageRevisitBroadcaster() {}
void PageRevisitBroadcaster::OnPageVisit(const GURL& url,
const ui::PageTransition transition) {
- if (ShouldSyncURL(url)) {
+ if (sessions_client_->ShouldSyncURL(url)) {
sync_sessions::PageVisitObserver::TransitionType converted(
ConvertTransitionEnum(transition));
for (auto* observer : revisit_observers_) {

Powered by Google App Engine
This is Rietveld 408576698