[Sync] Componentize synced_tab_delegate

components/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//tools/grit/repack.gni")
 
 # Collection of all components. You wouldn't link to this, but this is rather
@@ skipping 301 matching lines @@
     "//components/undo:unit_tests",
     "//net",
     "//ui/base",
     "//ui/resources:ui_test_pak",
     "//components/search_engines:unit_tests",
     "//components/undo:unit_tests",
     "//components/leveldb_proto:unit_tests",
     "//components/suggestions:unit_tests",
     "//components/omnibox/browser:unit_tests",
     "//components/sessions:test_support",
+    "//components/sessions:test_support",

[blundell, 2015/10/23 06:13:04]

(a) I think you mean to add //components/sync_sessions:test_support
(b) Presumably you need to make a corresponding change in components_tests.gyp?
(c) It's more in the spirit of how this target works to add this dependency on
the individual foo:unit_tests targets that need it (see tho comment at the top
of this deps list). Line 321 looks like a mistake.

[Nicolas Zea, 2015/10/23 22:18:14]

You're right. Fixed.

   ]
 
   if (!is_ios) {
     deps += [
       "//components/enhanced_bookmarks:unit_tests",
       "//components/error_page/renderer:unit_tests",
       "//components/guest_view/browser:unit_tests",
       "//components/navigation_interception:unit_tests",
       "//components/network_hints/renderer:unit_tests",
       "//components/power:unit_tests",
@@ skipping 284 matching lines @@
   ]
   if (!is_ios) {
     deps += [
       "//base",
       "//base/test:test_support_perf",
       "//content/test:test_support",
       "//components/visitedlink/browser",
     ]
   }
 }