[Sync] Componentize synced_tab_delegate

chrome/browser/sync/sessions/sessions_sync_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_
 #define CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 42 matching lines @@
 class SyncedWindowDelegatesGetter;
 
 // An interface defining the ways in which local open tab events can interact
 // with session sync.  All local tab events flow to sync via this interface.
 // In that way it is analogous to sync changes flowing to the local model
 // via ProcessSyncChanges, just with a more granular breakdown.
 class LocalSessionEventHandler {
  public:
   // A local navigation event took place that affects the synced session
   // for this instance of Chrome.
-  virtual void OnLocalTabModified(SyncedTabDelegate* modified_tab) = 0;
+  // Returns true if the tab had syncable data, false otherwise.
+  virtual bool OnLocalTabModified(SyncedTabDelegate* modified_tab) = 0;
 
   // A local navigation occurred that triggered updates to favicon data for
   // each page URL in |page_urls| (e.g. http://www.google.com) and the icon URL
   // |icon_url| (e.g. http://www.google.com/favicon.ico). This is routed through
   // Sessions Sync so that we can filter (exclude) favicon updates for pages
   // that aren't currently part of the set of local open tabs, and pass relevant
   // updates on to FaviconCache for out-of-band favicon syncing.
   virtual void OnFaviconsChanged(const std::set<GURL>& page_urls,
                                  const GURL& icon_url) = 0;
 };
 
 // The LocalSessionEventRouter is responsible for hooking itself up to various
 // notification sources in the browser process and forwarding relevant
 // events to a handler as defined in the LocalSessionEventHandler contract.
 class LocalSessionEventRouter {
  public:
   virtual ~LocalSessionEventRouter();
   virtual void StartRoutingTo(LocalSessionEventHandler* handler) = 0;
   virtual void Stop() = 0;
 };
 
 // Contains all logic for associating the Chrome sessions model and
 // the sync sessions model.
 class SessionsSyncManager : public syncer::SyncableService,
                             public sync_driver::OpenTabsUIDelegate,
                             public LocalSessionEventHandler {
  public:
   SessionsSyncManager(
+      sync_sessions::SyncSessionsClient* sessions_client,
       Profile* profile,
       sync_driver::LocalDeviceInfoProvider* local_device,
       scoped_ptr<LocalSessionEventRouter> router,
       scoped_ptr<SyncedWindowDelegatesGetter> synced_window_getter);
   ~SessionsSyncManager() override;
 
   // syncer::SyncableService implementation.
   syncer::SyncMergeResult MergeDataAndStartSyncing(
       syncer::ModelType type,
       const syncer::SyncDataList& initial_sync_data,
@@ skipping 18 matching lines @@
                      const SessionID::id_type tab_id,
                      const sessions::SessionTab** tab) override;
   bool GetForeignSessionTabs(
       const std::string& tag,
       std::vector<const sessions::SessionTab*>* tabs) override;
   void DeleteForeignSession(const std::string& tag) override;
   bool GetLocalSession(
       const sync_driver::SyncedSession** local_session) override;
 
   // LocalSessionEventHandler implementation.
-  void OnLocalTabModified(SyncedTabDelegate* modified_tab) override;
+  bool OnLocalTabModified(SyncedTabDelegate* modified_tab) override;
   void OnFaviconsChanged(const std::set<GURL>& page_urls,
                          const GURL& icon_url) override;
 
   // Returns the tag used to uniquely identify this machine's session in the
   // sync model.
   const std::string& current_machine_tag() const {
     DCHECK(!current_machine_tag_.empty());
     return current_machine_tag_;
   }
 
@@ skipping 195 matching lines @@
       syncer::SyncChangeList* change_output);
 
   // Stops and re-starts syncing to rebuild association mappings.
   // See |local_tab_pool_out_of_sync_|.
   void RebuildAssociations();
 
   // Validates the content of a SessionHeader protobuf.
   // Returns false if validation fails.
   static bool IsValidSessionHeader(const sync_pb::SessionHeader& header);
 
+  // The client of this sync sessions datatype.
+  sync_sessions::SyncSessionsClient* const sessions_client_;
+
   // Mapping of current open (local) tabs to their sync identifiers.
   TabLinksMap local_tab_map_;
 
   SyncedSessionTracker session_tracker_;
   FaviconCache favicon_cache_;
 
   // Pool of used/available sync nodes associated with local tabs.
   TabNodePool local_tab_pool_;
 
   // Tracks whether our local representation of which sync nodes map to what
@@ skipping 34 matching lines @@
 
   // Owns revisiting instrumentation logic for page visit events.
   PageRevisitBroadcaster page_revisit_broadcaster_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionsSyncManager);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_