[Sync] Componentize synced_tab_delegate

chrome/browser/sync/glue/synced_tab_delegate_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_ANDROID_H_
 
 #include "base/compiler_specific.h"
-#include "chrome/browser/sync/glue/synced_tab_delegate.h"
+#include "components/sync_sessions/synced_tab_delegate.h"
 #include "content/public/browser/web_contents_user_data.h"
 
 namespace content {
 class WebContents;
 }
 
 class TabAndroid;
 class TabContentsSyncedTabDelegate;
 
 namespace browser_sync {
 // On Android a tab can exist even without web contents.
 
 // SyncedTabDelegateAndroid wraps TabContentsSyncedTabDelegate and provides
 // a method to set web contents later when tab is brought to memory.
 class SyncedTabDelegateAndroid : public browser_sync::SyncedTabDelegate {
  public:
   explicit SyncedTabDelegateAndroid(TabAndroid* owning_tab_);
   ~SyncedTabDelegateAndroid() override;
 
-  // Methods from SyncedTabDelegate.
+  // SyncedTabDelegate:
   SessionID::id_type GetWindowId() const override;

[skym, 2015/10/16 16:55:46]

While you're in here, should probably #include for id_type.

[Nicolas Zea, 2015/10/20 23:14:41]

So, my interpretation of IWYU is that it's not necessary when it's a type you're
getting from the class you implement (with the exception of std libs). As such,
all the methods of SyncedTabDelegate are fine (and we therefore don't need to
duplicate all the includes rom synced tab delegate).

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/i_5qAOxe0xY
seems to confirm this

   SessionID::id_type GetSessionId() const override;
   bool IsBeingDestroyed() const override;
-  Profile* profile() const override;
   std::string GetExtensionAppId() const override;

[skym, 2015/10/16 16:55:47]

While you're in here, #include <string>. Although, I thought, the PRESUBMIT lint
check should have caught this one. /shrug

[Nicolas Zea, 2015/10/20 23:14:41]

Done.

   bool IsInitialBlankNavigation() const override;
   int GetCurrentEntryIndex() const override;
   int GetEntryCount() const override;
-  int GetPendingEntryIndex() const override;
-  content::NavigationEntry* GetPendingEntry() const override;
-  content::NavigationEntry* GetEntryAtIndex(int i) const override;
-  content::NavigationEntry* GetActiveEntry() const override;
+  GURL GetVirtualURLAtIndex(int i) const override;

[skym, 2015/10/16 16:55:46]

Forward declare GURL

[Nicolas Zea, 2015/10/20 23:14:41]

See above

+  GURL GetFaviconURLAtIndex(int i) const override;
+  ui::PageTransition GetTransitionAtIndex(int i) const override;

[skym, 2015/10/16 16:55:46]

#include for ui::PageTransition

[Nicolas Zea, 2015/10/20 23:14:41]

see above

+  void GetSerializedNavigationAtIndex(
+      int i,
+      sessions::SerializedNavigationEntry* serialized_entry) const override;

[skym, 2015/10/16 16:55:46]

Forward declare SerializedNavigationEntry

[Nicolas Zea, 2015/10/20 23:14:42]

See above.

   bool IsPinned() const override;
   bool HasWebContents() const override;
-  content::WebContents* GetWebContents() const override;
   int GetSyncId() const override;
   void SetSyncId(int sync_id) override;
-
-  // Supervised user related methods.
-
   bool ProfileIsSupervised() const override;
-  const std::vector<const content::NavigationEntry*>* GetBlockedNavigations()
-      const override;
+  const std::vector<const sessions::SerializedNavigationEntry*>*
+  GetBlockedNavigations() const override;

[skym, 2015/10/16 16:55:46]

Indentation looks odd here, might be the cr tool.

[Nicolas Zea, 2015/10/20 23:14:41]

Yeah, this is git cl format's work.

 
   // Set the web contents for this tab. Also creates
   // TabContentsSyncedTabDelegate for this tab.
   virtual void SetWebContents(content::WebContents* web_contents);
   // Set web contents to null.
   virtual void ResetWebContents();
 
  private:
   content::WebContents* web_contents_;
   TabAndroid* tab_android_;
   TabContentsSyncedTabDelegate* tab_contents_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncedTabDelegateAndroid);
 };
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_ANDROID_H_