[Sync] Componentize synced_tab_delegate

chrome/browser/sync/chrome_sync_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/chrome_sync_client.h"
 
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/prefs/pref_service_syncable_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/themes/theme_syncable_service.h"
 #include "chrome/browser/undo/bookmark_undo_service_factory.h"
 #include "chrome/browser/web_data_service_factory.h"
+#include "chrome/common/url_constants.h"
 #include "components/autofill/core/browser/webdata/autocomplete_syncable_service.h"
 #include "components/autofill/core/browser/webdata/autofill_profile_syncable_service.h"
 #include "components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h"
 #include "components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h"
 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
 #include "components/dom_distiller/core/dom_distiller_service.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/sync_driver/sync_api_component_factory.h"
 #include "components/syncable_prefs/pref_service_syncable.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/common/url_constants.h"
 
 #if defined(ENABLE_APP_LIST)
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
 #include "ui/app_list/app_list_switches.h"
 #endif
 
 #if defined(ENABLE_EXTENSIONS)
 #include "chrome/browser/extensions/api/storage/settings_sync_util.h"
 #include "chrome/browser/extensions/extension_sync_service.h"
@@ skipping 19 matching lines @@
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "components/wifi_sync/wifi_credential_syncable_service.h"
 #include "components/wifi_sync/wifi_credential_syncable_service_factory.h"
 #endif
 
 namespace browser_sync {
 
+// Chrome implementation of SyncSesssionsClient. Needs to be in a separate class

[maxbogue, 2015/10/17 21:53:58]

s/sss/ss/

[Nicolas Zea, 2015/10/20 23:14:41]

Done.

+// due to possible multiple inheritance issues, wherein ChromeSyncClient might
+// inherit from other interfaces with same methods.
+class SyncSessionsClientImpl : public sync_sessions::SyncSessionsClient {
+ public:
+  SyncSessionsClientImpl() {}
+  ~SyncSessionsClientImpl() override {}
+
+  // SyncSesssionsClient implementation.

[maxbogue, 2015/10/17 21:53:58]

s/sss/ss/

[Nicolas Zea, 2015/10/20 23:14:41]

Done.

+  bool ShouldSyncURL(const GURL& url) const override {
+    if (url == GURL(chrome::kChromeUIHistoryURL)) {
+      // The history page is treated specially as we want it to trigger syncable
+      // events for UI purposes.
+      return true;
+    }
+    return url.is_valid() && !url.SchemeIs(content::kChromeUIScheme) &&
+           !url.SchemeIs(chrome::kChromeNativeScheme) && !url.SchemeIsFile();
+  }
+};
+
 ChromeSyncClient::ChromeSyncClient(
     Profile* profile,
     scoped_ptr<sync_driver::SyncApiComponentFactory> component_factory)
-    : profile_(profile), component_factory_(component_factory.Pass()) {}
+    : profile_(profile),
+      component_factory_(component_factory.Pass()),
+      sync_sessions_client_(new SyncSessionsClientImpl()) {}
 ChromeSyncClient::~ChromeSyncClient() {
 }
 
 void ChromeSyncClient::Initialize(sync_driver::SyncService* sync_service) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   sync_service_ = sync_service;
   web_data_service_ = GetWebDataService();
   password_store_ = GetPasswordStore();
   component_factory_->RegisterDataTypes(this);
 }
@@ skipping 43 matching lines @@
 ChromeSyncClient::GetWebDataService() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   return WebDataServiceFactory::GetAutofillWebDataForProfile(
       profile_, ServiceAccessType::EXPLICIT_ACCESS);
 }
 
 BookmarkUndoService* ChromeSyncClient::GetBookmarkUndoServiceIfExists() {
   return BookmarkUndoServiceFactory::GetForProfileIfExists(profile_);
 }
 
+sync_sessions::SyncSessionsClient* ChromeSyncClient::GetSyncSessionsClient() {
+  return sync_sessions_client_.get();
+}
+
 base::WeakPtr<syncer::SyncableService>
 ChromeSyncClient::GetSyncableServiceForType(syncer::ModelType type) {
   if (!profile_) {  // For tests.
      return base::WeakPtr<syncer::SyncableService>();
   }
   switch (type) {
     case syncer::DEVICE_INFO:
       return ProfileSyncServiceFactory::GetForProfile(profile_)
           ->GetDeviceInfoSyncableService()
           ->AsWeakPtr();
@@ skipping 111 matching lines @@
       return base::WeakPtr<syncer::SyncableService>();
   }
 }
 
 sync_driver::SyncApiComponentFactory*
 ChromeSyncClient::GetSyncApiComponentFactory() {
   return component_factory_.get();
 }
 
 }  // namespace browser_sync