Issue 140863002: Fix spacing in create profile dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140863002: Fix spacing in create profile dialog. (Closed)

Created:
6 years, 11 months ago by Adrian Kuegel

Modified:
6 years, 11 months ago

Reviewers:
Pam (message me for reviews)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix spacing in create profile dialog. BUG=335051 TEST=open create profile dialog, observe spacing above create button. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245300

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/manage_profile_overlay.html	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Adrian Kuegel

Hi Pam, in https://codereview.chromium.org/125993002 I broke the spacing between the buttons and the checkbox, I ...

6 years, 11 months ago (2014-01-16 13:28:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/140863002/1

6 years, 11 months ago (2014-01-16 14:08:04 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247287

6 years, 11 months ago (2014-01-16 14:47:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/140863002/1

6 years, 11 months ago (2014-01-16 14:54:15 UTC) #5

Message was sent while issue was closed.

Change committed as 245300

Expand Messages | Collapse Messages