Issue 14086002: fix bug introduced with SK_IGNORE_CUBIC_STROKE_FIX where we no longer respected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14086002: fix bug introduced with SK_IGNORE_CUBIC_STROKE_FIX where we no longer respected (Closed)

Created:
7 years, 8 months ago by reed1

Modified:
7 years, 8 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

fix bug introduced with SK_IGNORE_CUBIC_STROKE_FIX where we no longer respected subDivide limit. This caused problems with degenate paths (too much recursion). The fix was two parts: 1. decrement the subDivide limit as we recurse 2. up the limit for cubics to 7, to match our current quality added unittest that replicated the too-much-recursion bug. Committed: https://code.google.com/p/skia/source/detail?r=8599

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -10 lines)			Patch
	M	src/core/SkStroke.cpp	View		3 chunks	+3 lines, -10 lines	0 comments	Download
	M	tests/PathTest.cpp	View		2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 8 months ago (2013-04-10 18:44:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8599 (presubmit successful).

Expand Messages | Collapse Messages