bench/nanobench.cpp - Issue 1408593002: Remove unnecessary allocation in nanobench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/nanobench.cpp

Issue 1408593002: Remove unnecessary allocation in nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/nanobench.cpp

diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp

index 781c09f769fb3248c5c787521d4aa65bd1ee52cb..a48e963a9ec65d69a2f668ce573dc10c581150d6 100644

--- a/bench/nanobench.cpp

+++ b/bench/nanobench.cpp

@@ -555,7 +555,6 @@ static bool valid_subset_bench(const SkString& path, SkColorType colorType, bool

SkPMColor colors[256];

int colorCount;

const SkImageInfo info = codec->getInfo().makeColorType(colorType);

- SkAutoTDeleteArray<uint8_t> row(new uint8_t[info.minRowBytes()]);

if (codec->startScanlineDecode(info, nullptr, colors, &colorCount) != SkCodec::kSuccess)

{

SkDebugf("Could not create scanline decoder for %s with color type %s. "

« no previous file with comments | « no previous file | no next file » | no next file with comments »