Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1408553002: Add bailout for large objects when allocating arrays in optimized code. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add bailout for large objects when allocating arrays in optimized code. BUG= Committed: https://crrev.com/0c81c4e924d7bdb45fce98209c21985d754e047d Cr-Commit-Position: refs/heads/master@{#31259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Michael Lippautz
Benedikt: PTAL. Happy for suggestions that avoid the hammer. Hannes: FYI.
5 years, 2 months ago (2015-10-14 11:04:37 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-14 11:05:01 UTC) #4
Benedikt Meurer
LGTM, I guess we need the hammer here, especially since this was completely unchecked before.
5 years, 2 months ago (2015-10-14 11:10:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408553002/1
5 years, 2 months ago (2015-10-14 11:44:45 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 12:41:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408553002/1
5 years, 2 months ago (2015-10-14 12:57:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 13:00:01 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c81c4e924d7bdb45fce98209c21985d754e047d Cr-Commit-Position: refs/heads/master@{#31259}
5 years, 2 months ago (2015-10-14 13:00:19 UTC) #13
Michael Achenbach
This breaks the deopt fuzzer, see: http://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/5634 Local repro: git co 0c81c4e924d7bdb45fce98209c21985d754e047d GYP_GENERATORS=ninja GYP_DEFINES="target_arch=ia32 v8_target_arch=ia32 ...
5 years, 2 months ago (2015-10-14 15:01:10 UTC) #14
Michael Achenbach
5 years, 2 months ago (2015-10-14 15:03:47 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1409543002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks deopt fuzzer:
http://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/5634

See comment in CL for repro..

Powered by Google App Engine
This is Rietveld 408576698