ui/file_manager/file_manager/foreground/js/navigation_list_model.js - Issue 1408533002: Turn on verbose flag for compiling file_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/navigation_list_model.js

Issue 1408533002: Turn on verbose flag for compiling file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address review comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/compile_js.gypi ('K') | « ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp ('k') | ui/file_manager/file_manager/foreground/js/ui/file_grid.js » ('j') | ui/file_manager/gallery/js/gallery_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/navigation_list_model.js

diff --git a/ui/file_manager/file_manager/foreground/js/navigation_list_model.js b/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

index a817289675397e7d046cd652602d7ce026a9a2b6..7d648e8b0886258ad0d9aff515a47adb315ac0f5 100644

--- a/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

+++ b/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

@@ -297,6 +297,7 @@ NavigationListModel.prototype.item = function(index) {

return this.shortcutList_[index - this.volumeList_.length];

if (index === this.length_() - 1)

return this.menuModel_;

+ return null;

Dan Beam 2015/10/20 00:33:37 is this necessary? should it be return undefined?

fukino 2015/10/20 04:13:07 I changed it to "return undefined" to be consisten

};

/**