Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: ui/file_manager/gallery/js/image_editor/image_transform.js

Issue 1408533002: Turn on verbose flag for compiling file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: List minimum set of externs in each gyp file, etc.. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/image_editor/image_transform.js
diff --git a/ui/file_manager/gallery/js/image_editor/image_transform.js b/ui/file_manager/gallery/js/image_editor/image_transform.js
index 47d9110dea1ac46e715e2ffd62c01999d1a6523a..a006f6b168ac657d0030851e179326e5fff66d99 100644
--- a/ui/file_manager/gallery/js/image_editor/image_transform.js
+++ b/ui/file_manager/gallery/js/image_editor/image_transform.js
@@ -16,43 +16,43 @@ ImageEditor.Mode.Crop = function() {
this.paddingBottom = ImageEditor.Mode.Crop.MOUSE_GRAB_RADIUS;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.domOverlay_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.shadowTop_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.middleBox_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.shadowLeft_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.cropFrame_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.shadowRight_ = null;
/**
- * @type {HTMLDivElement}
+ * @type {HTMLElement}
* @private
*/
this.shadowBottom_ = null;
@@ -82,31 +82,31 @@ ImageEditor.Mode.Crop.prototype.setUp = function() {
var container = this.getImageView().container_;
var doc = container.ownerDocument;
- this.domOverlay_ = doc.createElement('div');
+ this.domOverlay_ = assertInstanceof(doc.createElement('div'), HTMLElement);
Dan Beam 2015/10/21 01:35:26 assertInstanceof is not required, createElement on
fukino 2015/10/21 04:00:28 Do you suggest to use /** @type {!HTMLElement} */
this.domOverlay_.className = 'crop-overlay';
container.appendChild(this.domOverlay_);
- this.shadowTop_ = doc.createElement('div');
+ this.shadowTop_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.shadowTop_.className = 'shadow';
this.domOverlay_.appendChild(this.shadowTop_);
- this.middleBox_ = doc.createElement('div');
+ this.middleBox_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.middleBox_.className = 'middle-box';
this.domOverlay_.appendChild(this.middleBox_);
- this.shadowLeft_ = doc.createElement('div');
+ this.shadowLeft_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.shadowLeft_.className = 'shadow';
this.middleBox_.appendChild(this.shadowLeft_);
- this.cropFrame_ = doc.createElement('div');
+ this.cropFrame_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.cropFrame_.className = 'crop-frame';
this.middleBox_.appendChild(this.cropFrame_);
- this.shadowRight_ = doc.createElement('div');
+ this.shadowRight_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.shadowRight_.className = 'shadow';
this.middleBox_.appendChild(this.shadowRight_);
- this.shadowBottom_ = doc.createElement('div');
+ this.shadowBottom_ = assertInstanceof(doc.createElement('div'), HTMLElement);
this.shadowBottom_.className = 'shadow';
this.domOverlay_.appendChild(this.shadowBottom_);

Powered by Google App Engine
This is Rietveld 408576698