ui/file_manager/compile_js.gypi - Issue 1408533002: Turn on verbose flag for compiling file_manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/file_manager/compile_js.gypi

Issue 1408533002: Turn on verbose flag for compiling file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address review comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'variables': {

	6 'externs': [

	7 '<(EXTERNS_DIR)/chrome_extensions.js',

	8 '<(EXTERNS_DIR)/chrome_send.js',

	9 '<(EXTERNS_DIR)/command_line_private.js',

	10 '<(EXTERNS_DIR)/file_manager_private.js',

	11 '<(EXTERNS_DIR)/media_player_private.js',

	12 '<(EXTERNS_DIR)/metrics_private.js',
	Dan Beam 2015/10/19 16:10:28 is this common to ALL compiled_resources.gyp files is this common to ALL compiled_resources.gyp files in ui/file_manager? it doesn't seem like it fukino 2015/10/20 04:13:07 Actually, none of these externs are not common. I Show quoted text On 2015/10/19 16:10:28, Dan Beam wrote: > is this common to ALL compiled_resources.gyp files in ui/file_manager? it > doesn't seem like it Actually, none of these externs are not common. I listed minimum set of externs in each compiled_resources.js
	13 ],

	14 'closure_args': [

	15 'warning_level=VERBOSE',

	16 ],

	17 },

	18 'includes': ['../../third_party/closure_compiler/compile_js.gypi'],

	19 }

OLD	NEW