Issue 1408513002: Revert "Remove IPDFSDK_AnnotHandler interface."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408513002: Revert "Remove IPDFSDK_AnnotHandler interface." (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove IPDFSDK_AnnotHandler interface." This reverts commit 633f1e436e1cced874a44a797f02c452eb3cf958. This restores IPDFSDK_AnnotHandler, which is pointless on master but useful on XFA. The small gain on master isn't worth the noise when diffing to XFA. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/24c1eec13f277f27cb27edfb3d191e8bd2223e7c

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -134 lines)			Patch
	M	fpdfsdk/include/fsdk_annothandler.h	View		4 chunks	+148 lines, -44 lines	0 comments	Download
	M	fpdfsdk/src/fsdk_annothandler.cpp	View		45 chunks	+90 lines, -90 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, need approval for the concept. The revert is automatic.

5 years, 2 months ago (2015-10-13 22:15:14 UTC) #2

Lei Zhang

lgtm Ya, my bidi merge to XFA CL is stuck in limbo because removing an ...

5 years, 2 months ago (2015-10-13 22:17:21 UTC) #3

Tom Sepez

5 years, 2 months ago (2015-10-13 22:22:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
24c1eec13f277f27cb27edfb3d191e8bd2223e7c (presubmit successful).