Issue 1408443002: Fix order of initialization warning in target_process.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408443002: Fix order of initialization warning in target_process.cc. (Closed)

Created:
5 years, 2 months ago by hans

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix order of initialization warning in target_process.cc. The build was failing with the following Clang error: ..\..\sandbox\win\src\target_process.cc(77,7): error: field 'initial_token_' will be initialized after field 'lowbox_token_' [-Werror,-Wreorder] initial_token_(initial_token.Pass()), ^ BUG=82385 TBR=forshaw Committed: https://chromium.googlesource.com/chromium/src/+/9118aca83ca5a71ec91f1b345e86344ba2616f6b

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	sandbox/win/src/target_process.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9118aca83ca5a71ec91f1b345e86344ba2616f6b Cr-Commit-Position: refs/heads/master@{#353765}

5 years, 2 months ago (2015-10-13 16:01:57 UTC) #1

hans

5 years, 2 months ago (2015-10-13 16:02:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9118aca83ca5a71ec91f1b345e86344ba2616f6b (presubmit successful).

Expand Messages | Collapse Messages