Chromium Code Reviews| Index: net/http/http_auth_handler_factory.h |
| diff --git a/net/http/http_auth_handler_factory.h b/net/http/http_auth_handler_factory.h |
| index a98f9d7f4b1a89b4eee3e591f5d67ef85ae49d70..ac6e9e79bd5665529b8377a65b4be6617035858c 100644 |
| --- a/net/http/http_auth_handler_factory.h |
| +++ b/net/http/http_auth_handler_factory.h |
| @@ -79,8 +79,11 @@ class NET_EXPORT HttpAuthHandlerFactory { |
| // NOTE: This will apply to ALL |origin| values if the filters are empty. |
| // |
| // |*challenge| should not be reused after a call to |CreateAuthHandler()|, |
| + // |
| + // TODO(asanka): Update comment. |
|
Ryan Sleevi
2016/03/18 21:27:40
*cough*? ;)
asanka
2016/03/23 04:51:30
:-P
Comments updated here and elsewhere.
|
| virtual int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge, |
| HttpAuth::Target target, |
| + const HttpResponseInfo& response_info, |
| const GURL& origin, |
| CreateReason create_reason, |
| int digest_nonce_count, |
| @@ -92,8 +95,11 @@ class NET_EXPORT HttpAuthHandlerFactory { |
| // This is a convenience function which creates a ChallengeTokenizer for |
| // |challenge| and calls |CreateAuthHandler|. See |CreateAuthHandler| for |
| // more details on return values. |
| + // |
| + // TODO(asanka): Update comment. |
|
Ryan Sleevi
2016/03/18 21:27:40
*cough* ;)
|
| int CreateAuthHandlerFromString(const std::string& challenge, |
| HttpAuth::Target target, |
| + const HttpResponseInfo& response_info, |
| const GURL& origin, |
| const BoundNetLog& net_log, |
| scoped_ptr<HttpAuthHandler>* handler); |
| @@ -177,6 +183,7 @@ class NET_EXPORT HttpAuthHandlerRegistryFactory |
| // based on the first token in |challenge|. |
| int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge, |
| HttpAuth::Target target, |
| + const HttpResponseInfo& response_info, |
| const GURL& origin, |
| CreateReason reason, |
| int digest_nonce_count, |