net/android/http_auth_negotiate_android_unittest.cc - Issue 1408433006: Support tls-server-end-point channel bindings for HTTP authentication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/http_auth_negotiate_android_unittest.cc

Issue 1408433006: Support tls-server-end-point channel bindings for HTTP authentication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Narrower dependencies, update comments, address review comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/android/http_auth_negotiate_android_unittest.cc

diff --git a/net/android/http_auth_negotiate_android_unittest.cc b/net/android/http_auth_negotiate_android_unittest.cc

index 8e3de79485c1f2c75748048befaf5dc70b2b81a6..b44547d1b16f8bbcb248e7626ebb8a45202cf217 100644

--- a/net/android/http_auth_negotiate_android_unittest.cc

+++ b/net/android/http_auth_negotiate_android_unittest.cc

@@ -31,8 +31,9 @@ TEST(HttpAuthNegotiateAndroidTest, GenerateAuthToken) {

EXPECT_TRUE(auth.Init());

TestCompletionCallback callback;

- EXPECT_EQ(OK, callback.GetResult(auth.GenerateAuthToken(

- nullptr, "Dummy", &auth_token, callback.callback())));

+ EXPECT_EQ(OK, callback.GetResult(

+ auth.GenerateAuthToken(nullptr, "Dummy", std::string(),

+ &auth_token, callback.callback())));

EXPECT_EQ("Negotiate DummyToken", auth_token);

« no previous file with comments | « net/android/http_auth_negotiate_android.cc ('k') | net/cert/x509_util.h » ('j') | net/cert/x509_util_openssl.cc » ('J')