Implement browser-side logging to WebRtc log

content/browser/renderer_host/media/media_stream_manager.h

Index: content/browser/renderer_host/media/media_stream_manager.h
diff --git a/content/browser/renderer_host/media/media_stream_manager.h b/content/browser/renderer_host/media/media_stream_manager.h
index eefab6bdcb2087ddfc4890a8f7b1c93a3691050f..01f436b400aedd9e3dc5f7462a90547aef912617 100644
--- a/content/browser/renderer_host/media/media_stream_manager.h
+++ b/content/browser/renderer_host/media/media_stream_manager.h
@@ -185,6 +185,11 @@ class CONTENT_EXPORT MediaStreamManager
   // too late. (see http://crbug.com/247525#c14).
   virtual void WillDestroyCurrentMessageLoop() OVERRIDE;
 
+  // Adds |message| to native logs for outstanding device requests, for use by
+  // render processes requesting logging from webrtcLoggingPrivate API.
+  void AddLogMessageOnUIThread(const std::string& message);
+  static void SendMessageToNativeLog(const std::string& message);

[perkj_chrome, 2014/01/24 09:15:10]

Can you add a comment that it is safe to call SendMessageToNativeLog on any
thread?
You are sending from an "unknown" thread in
VideoCaptureController::VideoCaptureDeviceClient::OnError".

[no longer working on chromium, 2014/01/24 09:54:38]

will this static API be used outside MediaStreamManager? if not, move it to
private.

[tommi (sloooow) - chröme, 2014/01/24 12:34:54]

+1 on documenting this function like the other methods.

[vrk (LEFT CHROMIUM), 2014/01/25 00:50:21]

Done.

[vrk (LEFT CHROMIUM), 2014/01/25 00:50:21]

Done.

[vrk (LEFT CHROMIUM), 2014/01/25 00:50:21]

Yes, it's already used in VideoCaptureController::VideoCaptureDeviceClient in
this CL. (Btw, an easy way to check is to view the raw patch (click [raw] link
next to Download) and search for ::SendMessageToNativeLog to search the whole
CL). Also, the point of this method is to allow logging from any class in the
browser process in chrome/ or content/.

+
  protected:
   // Used for testing.
   MediaStreamManager();
@@ -320,6 +325,11 @@ class CONTENT_EXPORT MediaStreamManager
       const std::string& source_id,
       std::string* device_id) const;
 
+  // Sends |stream_type| and the contents of |devices| to the
+  // webrtcLoggingPrivate API.
+  void LogDevicesToNativeLogs(MediaStreamType stream_type,
+                              const StreamDeviceInfoArray& devices);
+
   // Device thread shared by VideoCaptureManager and AudioInputDeviceManager.
   scoped_ptr<base::Thread> device_thread_;