Implement browser-side logging to WebRtc log

content/browser/renderer_host/media/video_capture_manager.cc

Index: content/browser/renderer_host/media/video_capture_manager.cc
diff --git a/content/browser/renderer_host/media/video_capture_manager.cc b/content/browser/renderer_host/media/video_capture_manager.cc
index 307a1b1aab10e248d7bcdc936df48671ee91f549..75414e1b96628c409d4487c4b460b70a06bbb3be 100644
--- a/content/browser/renderer_host/media/video_capture_manager.cc
+++ b/content/browser/renderer_host/media/video_capture_manager.cc
@@ -11,8 +11,10 @@
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include "content/browser/renderer_host/media/media_stream_manager.h"

[perkj_chrome, 2014/01/20 11:07:08]

I think this include is the wrong direction.
If you actually want to log device enumeration and open / closing devices why
not only do it in MediaStreamManager.

[vrk (LEFT CHROMIUM), 2014/01/22 02:25:42]

I was originally going to add more logging in a separate CL, but I added video
capture logging to this CL so you can better see the necessity for a static
logging method on MediaStreamManager. PTAL.

 #include "content/browser/renderer_host/media/video_capture_controller.h"
 #include "content/browser/renderer_host/media/video_capture_controller_event_handler.h"
 #include "content/browser/renderer_host/media/web_contents_video_capture_device.h"
@@ -436,6 +438,8 @@ VideoCaptureManager::GetAvailableDevicesInfoOnDeviceThread(
     }
   }
 
+  MediaStreamManager::AddLogMessage(
+      "VCM::GADIODT found the following devices:");

[Henrik Grunell, 2014/01/17 08:51:25]

If there's no devices, will that be clear to the log reader? Should there be a
special log message for that?

[vrk (LEFT CHROMIUM), 2014/01/22 02:25:42]

Sure, added special log message for this case.

   // Get the supported capture formats for the new devices in |names_snapshot|.
   for (media::VideoCaptureDevice::Names::const_iterator it =
            names_snapshot.begin();
@@ -457,6 +461,8 @@ VideoCaptureManager::GetAvailableDevicesInfoOnDeviceThread(
         break;
     }
     new_devices_info_cache.push_back(device_info);
+    MediaStreamManager::AddLogMessage(device_info.name.GetNameAndModel() + "(" +

[Henrik Grunell, 2014/01/17 08:51:25]

Perhaps " ("? (Space added)

[vrk (LEFT CHROMIUM), 2014/01/22 02:25:42]

Done.

+                                      device_info.name.id());

[Henrik Grunell, 2014/01/17 08:51:25]

End string with ")"?

[vrk (LEFT CHROMIUM), 2014/01/22 02:25:42]

Done.

   }
   return new_devices_info_cache;
 }