Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: content/browser/renderer_host/media/audio_input_device_manager.cc

Issue 140843007: Implement browser-side logging to WebRtc log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_device_manager.cc
diff --git a/content/browser/renderer_host/media/audio_input_device_manager.cc b/content/browser/renderer_host/media/audio_input_device_manager.cc
index cfe00caea329693934194a3c67c18d8758e0dddd..b5ad555017db558ab5739ac2238d76795447985c 100644
--- a/content/browser/renderer_host/media/audio_input_device_manager.cc
+++ b/content/browser/renderer_host/media/audio_input_device_manager.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/memory/scoped_ptr.h"
+#include "content/browser/renderer_host/media/media_stream_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/common/media_stream_request.h"
#include "media/audio/audio_device_name.h"
@@ -138,12 +139,15 @@ void AudioInputDeviceManager::EnumerateOnDeviceThread(
break;
}
+ MediaStreamManager::AddLogMessage(
perkj_chrome 2014/01/20 11:07:08 Why do we have to log here? Why not do it in Medi
vrk (LEFT CHROMIUM) 2014/01/22 02:25:42 Sure, I can do that. I originally put more logging
+ "AIDM::EODTT found the following devices:");
Henrik Grunell 2014/01/17 08:51:25 Same comments as in VideoCaptureManager for this a
vrk (LEFT CHROMIUM) 2014/01/22 02:25:42 Done.
scoped_ptr<StreamDeviceInfoArray> devices(new StreamDeviceInfoArray());
for (media::AudioDeviceNames::iterator it = device_names.begin();
it != device_names.end(); ++it) {
// Add device information to device vector.
devices->push_back(StreamDeviceInfo(
stream_type, it->device_name, it->unique_id));
+ MediaStreamManager::AddLogMessage(it->device_name + "(" + it->unique_id);
}
// If the |use_fake_device_| flag is on, inject the fake device if there is

Powered by Google App Engine
This is Rietveld 408576698