[Intl] Cleanup some code

pkg/intl/lib/generate_localized.dart

Index: pkg/intl/lib/generate_localized.dart
diff --git a/pkg/intl/lib/generate_localized.dart b/pkg/intl/lib/generate_localized.dart
index 0095c8936dd14abfd83c1ab9194f1a1b7cca625e..f6662a33a03f8c51b3baf8436747214389bb0a9a 100644
--- a/pkg/intl/lib/generate_localized.dart
+++ b/pkg/intl/lib/generate_localized.dart
@@ -66,10 +66,10 @@ abstract class TranslatedMessage {
    * but it can be any identifier that this program and the output of the
    * translation can agree on as identifying a message.
    */
-  String id;
+  final String id;
 
   /** Our translated version of [originalMessage]. */
-  Message translated;
+  final Message translated;
 
   /** The original message that we are a translation of. */
   MainMessage originalMessage;
@@ -106,16 +106,15 @@ void generateIndividualMessageFile(String locale,
   usableTranslations.sort((a, b) =>
       a.originalMessage.name.compareTo(b.originalMessage.name));
   for (var translation in usableTranslations) {
-    result.write("  ");
-    result.write(translation.originalMessage.toCodeForLocale(locale));
-    result.write("\n\n");
+    result..write("  ")

[Alan Knight, 2014/01/28 01:33:46]

I think the cascades should all line up and this one should be on a separate
line to match with the others.

[vicb, 2014/01/28 07:52:45]

fixed

+        ..write(translation.originalMessage.toCodeForLocale(locale))
+        ..write("\n\n");
   }
   result.write("\n  final messages = const {\n");
   var entries = usableTranslations
       .map((translation) => translation.originalMessage.name)
       .map((name) => "    \"$name\" : $name");
-  result.write(entries.join(",\n"));
-  result.write("\n  };\n}");
+  result.writeAll([entries.join(",\n"), "\n  };\n}"]);

[Alan Knight, 2014/01/28 01:33:46]

This to me seems less clear than having it as two separate lines. It's too easy
to get lost in a maze of twisty little punctuation characters.

[vicb, 2014/01/28 07:52:45]

I've changed because I (personal preferences) find it more readable and I know
that some script language have expense method calls (ie context switch) and this
version would be more efficient.
Thoughts ?

[Alan Knight, 2014/01/29 01:27:58]

Method calls should not be expensive at all in Dart. If anything, allocating a
new List just to access the two entries would be more expensive. I can see it
being more readable in some circumstances, but with so many special characters
in the strings I think it's better to have them on separate lines.

[vicb, 2014/01/29 08:15:14]

reverted

 
   var output = new File(path.join(targetDir,
       "${generatedFilePrefix}messages_$locale.dart"));