[Intl] Cleanup some code

pkg/intl/lib/date_symbols.dart

Index: pkg/intl/lib/date_symbols.dart
diff --git a/pkg/intl/lib/date_symbols.dart b/pkg/intl/lib/date_symbols.dart
index cd0b9d2fed4b97774f2847bf0eb4c39bfa5ae05e..fb2dbcf64e8d64f41e02cdde6ad37438951ffcf3 100644
--- a/pkg/intl/lib/date_symbols.dart
+++ b/pkg/intl/lib/date_symbols.dart
@@ -83,32 +83,32 @@ class DateSymbols {
   }
 
   Map serializeToMap() {
-    var map = new Map();
-    map["NAME"] = NAME;
-    map["ERAS"] = ERAS;
-    map["ERANAMES"] = ERANAMES;
-    map["NARROWMONTHS"] = NARROWMONTHS;
-    map["STANDALONENARROWMONTHS"] = STANDALONENARROWMONTHS;
-    map["MONTHS"] = MONTHS;
-    map["STANDALONEMONTHS"] = STANDALONEMONTHS;
-    map["SHORTMONTHS"] = SHORTMONTHS;
-    map["STANDALONESHORTMONTHS"] = STANDALONESHORTMONTHS;
-    map["WEEKDAYS"] = WEEKDAYS;
-    map["STANDALONEWEEKDAYS"] = STANDALONEWEEKDAYS;
-    map["SHORTWEEKDAYS"] = SHORTWEEKDAYS;
-    map["STANDALONESHORTWEEKDAYS"] = STANDALONESHORTWEEKDAYS;
-    map["NARROWWEEKDAYS"] = NARROWWEEKDAYS;
-    map["STANDALONENARROWWEEKDAYS"] = STANDALONENARROWWEEKDAYS;
-    map["SHORTQUARTERS"] = SHORTQUARTERS;
-    map["QUARTERS"] = QUARTERS;
-    map["AMPMS"] = AMPMS;
-    map["DATEFORMATS"] = DATEFORMATS;
-    map["TIMEFORMATS"] = TIMEFORMATS;
-    map["AVAILABLEFORMATS"] = AVAILABLEFORMATS;
-    map["FIRSTDAYOFWEEK"] = FIRSTDAYOFWEEK;
-    map["WEEKENDRANGE"] = WEEKENDRANGE;
-    map["FIRSTWEEKCUTOFFDAY"] = FIRSTWEEKCUTOFFDAY;
-    return map;
+    return {
+        "NAME": NAME,

[Alan Knight, 2014/01/28 01:33:46]

I think the style guide would indent the map elements only two. Also, at this
point, couldn't this just be a lambda?

[vicb, 2014/01/28 07:52:45]

Indentation fixed.

Not easy to change for a lambda as the method return a map.

[Alan Knight, 2014/01/29 01:27:58]

Why isn't that easy?  foo() => { "hello" : 1, "world" : 2}; is perfectly
allowable syntax.

[vicb, 2014/01/29 08:15:14]

I misunderstood... I was think of replacing the map itself with a closure.
fixed.

+        "ERAS": ERAS,
+        "ERANAMES": ERANAMES,
+        "NARROWMONTHS": NARROWMONTHS,
+        "STANDALONENARROWMONTHS": STANDALONENARROWMONTHS,
+        "MONTHS": MONTHS,
+        "STANDALONEMONTHS": STANDALONEMONTHS,
+        "SHORTMONTHS": SHORTMONTHS,
+        "STANDALONESHORTMONTHS": STANDALONESHORTMONTHS,
+        "WEEKDAYS": WEEKDAYS,
+        "STANDALONEWEEKDAYS": STANDALONEWEEKDAYS,
+        "SHORTWEEKDAYS": SHORTWEEKDAYS,
+        "STANDALONESHORTWEEKDAYS": STANDALONESHORTWEEKDAYS,
+        "NARROWWEEKDAYS": NARROWWEEKDAYS,
+        "STANDALONENARROWWEEKDAYS": STANDALONENARROWWEEKDAYS,
+        "SHORTQUARTERS": SHORTQUARTERS,
+        "QUARTERS": QUARTERS,
+        "AMPMS": AMPMS,
+        "DATEFORMATS": DATEFORMATS,
+        "TIMEFORMATS": TIMEFORMATS,
+        "AVAILABLEFORMATS": AVAILABLEFORMATS,
+        "FIRSTDAYOFWEEK": FIRSTDAYOFWEEK,
+        "WEEKENDRANGE": WEEKENDRANGE,
+        "FIRSTWEEKCUTOFFDAY": FIRSTWEEKCUTOFFDAY
+    };
   }
 
   toString() => NAME;
@@ -201,4 +201,4 @@ var en_USPatterns = const {
   'z': 'z', // ABBR_SPECIFIC_TZ
   'zzzz': 'zzzz', // SPECIFIC_TZ
   'ZZZZ': 'ZZZZ'  // ABBR_UTC_TZ
-};
+};