[Intl] Cleanup some code

pkg/intl/lib/generate_localized.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This provides utilities for generating localized versions of
  * messages. It does not stand alone, but expects to be given
  * TranslatedMessage objects and generate code for a particular locale
  * based on them.
  *
@@ skipping 48 matching lines @@
  * into a Dart string interpolation. Specific translation
  * mechanisms are expected to subclass this.
  */
 abstract class TranslatedMessage {
   /**
    * The identifier for this message. In the simplest case, this is the name
    * parameter from the Intl.message call,
    * but it can be any identifier that this program and the output of the
    * translation can agree on as identifying a message.
    */
-  String id;
+  final String id;
 
   /** Our translated version of [originalMessage]. */
-  Message translated;
+  final Message translated;
 
   /** The original message that we are a translation of. */
   MainMessage originalMessage;
 
   TranslatedMessage(this.id, this.translated);
 
   Message get message => translated;
 
   toString() => id.toString();
 }
@@ skipping 16 matching lines @@
   // Exclude messages with no translation and translations with no matching
   // original message (e.g. if we're using some messages from a larger catalog)
   var usableTranslations =  translations.where(
       (each) => each.originalMessage != null && each.message != null).toList();
   for (var each in usableTranslations) {
       each.originalMessage.addTranslation(locale, each.message);
   }
   usableTranslations.sort((a, b) =>
       a.originalMessage.name.compareTo(b.originalMessage.name));
   for (var translation in usableTranslations) {
-    result.write("  ");
-    result.write(translation.originalMessage.toCodeForLocale(locale));
-    result.write("\n\n");
+    result..write("  ")

[Alan Knight, 2014/01/28 01:33:46]

I think the cascades should all line up and this one should be on a separate
line to match with the others.

[vicb, 2014/01/28 07:52:45]

fixed

+        ..write(translation.originalMessage.toCodeForLocale(locale))
+        ..write("\n\n");
   }
   result.write("\n  final messages = const {\n");
   var entries = usableTranslations
       .map((translation) => translation.originalMessage.name)
       .map((name) => "    \"$name\" : $name");
-  result.write(entries.join(",\n"));
-  result.write("\n  };\n}");
+  result.writeAll([entries.join(",\n"), "\n  };\n}"]);

[Alan Knight, 2014/01/28 01:33:46]

This to me seems less clear than having it as two separate lines. It's too easy
to get lost in a maze of twisty little punctuation characters.

[vicb, 2014/01/28 07:52:45]

I've changed because I (personal preferences) find it more readable and I know
that some script language have expense method calls (ie context switch) and this
version would be more efficient.
Thoughts ?

[Alan Knight, 2014/01/29 01:27:58]

Method calls should not be expensive at all in Dart. If anything, allocating a
new List just to access the two entries would be more expensive. I can see it
being more readable in some circumstances, but with so many special characters
in the strings I think it's better to have them on separate lines.

[vicb, 2014/01/29 08:15:14]

reverted

 
   var output = new File(path.join(targetDir,
       "${generatedFilePrefix}messages_$locale.dart"));
   output.writeAsStringSync(result.toString());
 }
 
 /**
  * This returns the mostly constant string used in
  * [generateIndividualMessageFile] for the beginning of the file,
  * parameterized by [locale].
@@ skipping 94 matching lines @@
   // return lib == null ? new Future.value(false) : lib.load();
   return new Future.value(true);
 }
 
 MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
   var actualLocale = Intl.verifiedLocale(locale, (x) => _findExact(x) != null);
   if (actualLocale == null) return null;
   return _findExact(actualLocale);
 }
 """;