components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Vaclav's inputs. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index dc87799d0c887b0be691584de12d78b1ac649477..e600fcd2980726378412d5c57c2d329493837436 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -364,6 +364,7 @@ bool GetPasswordForm(const SyntheticForm& form,

// was made readonly by JavaScript before submission. We can do this by

// checking whether password element was updated not from JavaScript.

if (input_element->isPasswordField() &&

+ form_util::IsWebNodeVisible(*input_element) &&

(!input_element->isReadOnly() ||

(nonscript_modified_values &&

nonscript_modified_values->find(*input_element) !=

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | no next file » | no next file with comments »