components/autofill/content/renderer/password_form_conversion_utils.h - Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more handling. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.h

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h

index 42092289f5a743643de1d3a4f1d27b5f144b00a4..dd0ae625bd7d8763a134d5317f0a0cdcfc4a3867 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.h

+++ b/components/autofill/content/renderer/password_form_conversion_utils.h

@@ -64,6 +64,9 @@ scoped_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(

bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,

const char* value_in_lowercase);

+// Returns true if |input_element| is hidden.

vabr (Chromium) 2015/10/20 16:40:23 No need for this one, use IsWebNodeVisible from co

Pritam Nikam 2015/10/22 09:00:08 Done.

+bool IsInputElementHidden(blink::WebInputElement* input_element);

} // namespace autofill

#endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H__