[Password Manager] Ignore autofilling invisible password fields.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/i18n/case_conversion.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 167 matching lines @@
     if (!control_element.hasHTMLTagName("input"))
       continue;
 
     // Only fill saved passwords into password fields and usernames into text
     // fields.
     const blink::WebInputElement input_element =
         control_element.toConst<blink::WebInputElement>();
     if (input_element.isPasswordField() != is_password_field)
       continue;
 
+    // Avoid autofilling invisible password fields.
+    if (input_element.isPasswordField() &&
+        IsInputElementHidden((blink::WebInputElement*)&input_element)) {

[vabr (Chromium), 2015/10/20 16:40:22]

Please use IsWebNodeVisible. That will also get rid of the forbidden C-style
cast (do not ever use them in Chromium, use C++-style if necessary).

[Pritam Nikam, 2015/10/22 09:00:08]

Done.

+      continue;
+    }
+
     // For change password form with ambiguous or empty names keep only the
     // first password field having |autocomplete='current-password'| attribute
     // set. Also make sure we avoid keeping password fields having
     // |autocomplete='new-password'| attribute set.
     if (ambiguous_and_multiple_password_fields_with_autocomplete &&
         !HasAutocompleteAttributeValue(input_element, "current-password")) {
       continue;
     }
 
     // Check for a non-unique match.
@@ skipping 1327 matching lines @@
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::DidStopLoading() {
   agent_->DidStopLoading();
 }
 
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
     DidStartProvisionalLoad(blink::WebLocalFrame* navigated_frame) {
   agent_->LegacyDidStartProvisionalLoad(navigated_frame);
 }
 
 }  // namespace autofill