Boilerplate code to add chrome://syncfs-internals page for debugging.

Boilerplate code to add chrome://syncfs-internals page for debugging SyncFileSystem. Will add the event code and event handlers in JS in next patch.

BUG=226353
TEST=Go to chrome://syncfs-internals and see something.
TBR=arv@chromium.org, thestig@chromium.org, tzik@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197845

[calvinlo, 2013-04-22 09:36:52]

Tzik san, can you please take a look before I send this out for owners reviewer.
thanks.

[tzik, 2013-04-22 14:07:57]

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
File chrome/browser/resources/sync_file_system_internals/main.css (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.css:1: /* Copyright (c)
2012 The Chromium Authors. All rights reserved.
license header?

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.css:12:
#tree-view-container {
can we drop this until we use it?

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
File chrome/browser/resources/sync_file_system_internals/main.html (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.html:3: Copyright (c)
2011 The Chromium Authors. All rights reserved.
license header?

https://codereview.chromium.org/14084008/diff/2001/chrome/common/url_constant...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/common/url_constant...
chrome/common/url_constants.cc:199: "sync-file-system-internals";
chrome://sync-file-system-internals looks too long.
can we use chrome://syncfs-internals?

[calvinlo, 2013-04-23 05:48:49]

Fixed license headers for all new files on top of ones indicated.

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
File chrome/browser/resources/sync_file_system_internals/main.css (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.css:1: /* Copyright (c)
2012 The Chromium Authors. All rights reserved.
On 2013/04/22 14:07:57, tzik wrote:
> license header?

Done.

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.css:12:
#tree-view-container {
On 2013/04/22 14:07:57, tzik wrote:
> can we drop this until we use it?

Done.

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
File chrome/browser/resources/sync_file_system_internals/main.html (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/browser/resources/s...
chrome/browser/resources/sync_file_system_internals/main.html:3: Copyright (c)
2011 The Chromium Authors. All rights reserved.
On 2013/04/22 14:07:57, tzik wrote:
> license header?

Done.

https://codereview.chromium.org/14084008/diff/2001/chrome/common/url_constant...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/14084008/diff/2001/chrome/common/url_constant...
chrome/common/url_constants.cc:199: "sync-file-system-internals";
On 2013/04/22 14:07:57, tzik wrote:
> chrome://sync-file-system-internals looks too long.
> can we use chrome://syncfs-internals?

Done. Kinuko OKed the shorter name.

[tzik, 2013-04-23 06:04:30]

lgtm

[kinuko, 2013-04-23 06:15:14]

nit: it'd be better to update the issue subject & description (for the internal
URL change)

[calvinlo, 2013-04-23 06:28:33]

+thestig for *.gypi, *.gyp files
+arv for OWNERS reviewer for chrome/browser/resources* and
chrome/browser/ui/webui/*

Kinuko, thanks, updated URLs in issue summary and description.

[kinuko, 2013-04-23 06:29:30]

(some more nits, style/copyright issues only)

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
File chrome/browser/resources/sync_file_system_internals/main.css (right):

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
chrome/browser/resources/sync_file_system_internals/main.css:1: /* Copyright
2013 The Chromium Authors. All rights reserved.
nit: '(c) 2013'

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.h (right):

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.h:6: #define
CHROME_BROWSER_UI_WEBUI_SYNC_FILE_SYSTEM_INTERNALS_UI_H_
nit: usually we seem to put an empty line after include guards

[calvinlo, 2013-04-23 06:48:29]

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
File chrome/browser/resources/sync_file_system_internals/main.css (right):

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
chrome/browser/resources/sync_file_system_internals/main.css:1: /* Copyright
2013 The Chromium Authors. All rights reserved.
On 2013/04/23 06:29:30, kinuko wrote:
> nit: '(c) 2013'

Another reviewer sent me this link:
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-o...

which seems to indicate that the (c) should not be introduced into copyright
notices on new files unless you've seen an even newer post which overrides this
one from Aug 2012

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.h (right):

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.h:6: #define
CHROME_BROWSER_UI_WEBUI_SYNC_FILE_SYSTEM_INTERNALS_UI_H_
On 2013/04/23 06:29:30, kinuko wrote:
> nit: usually we seem to put an empty line after include guards

Done.

[kinuko, 2013-04-23 07:04:09]

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
File chrome/browser/resources/sync_file_system_internals/main.css (right):

https://codereview.chromium.org/14084008/diff/17001/chrome/browser/resources/...
chrome/browser/resources/sync_file_system_internals/main.css:1: /* Copyright
2013 The Chromium Authors. All rights reserved.
On 2013/04/23 06:48:29, calvinlo wrote:
> On 2013/04/23 06:29:30, kinuko wrote:
> > nit: '(c) 2013'
> 
> Another reviewer sent me this link:
>
https://groups.google.com/a/chromium.org/forum/?fromgroups=#%21topic/chromium...
> 
> which seems to indicate that the (c) should not be introduced into copyright
> notices on new files unless you've seen an even newer post which overrides
this
> one from Aug 2012

Oh, ok I didn't know that. Thx for the link!

[Lei Zhang, 2013-04-23 18:26:48]

chrome/ bits outside of chrome/browser/resources lgtm with nits below:

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.cc (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:7: #include <string>
not used

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:11: #include
"content/public/browser/web_contents.h"
not used

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:15: #include
"ui/base/l10n/l10n_util.h"
not used

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:16: #include
"ui/base/resource/resource_bundle.h"
not used

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:18: using
content::WebContents;
not used

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.h (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.h:13: virtual
~SyncFileSystemInternalsUI() {}
Please keep the implementation out of header files.

[arv (Not doing code reviews), 2013-04-23 18:54:32]

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/resources/...
File chrome/browser/resources/sync_file_system_internals/main.html (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/resources/...
chrome/browser/resources/sync_file_system_internals/main.html:17: <link
rel="stylesheet" href="chrome://resources/css/tree.css">
I don't see where you are using a tree?

[calvinlo, 2013-04-24 07:53:23]

Thanks. Sorry, I'll be more careful to remove unused imports when copying and
pasting boilerplate from existing files next time.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/resources/...
File chrome/browser/resources/sync_file_system_internals/main.html (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/resources/...
chrome/browser/resources/sync_file_system_internals/main.html:17: <link
rel="stylesheet" href="chrome://resources/css/tree.css">
Removed. I should have cleaned this up after I copied and pasted from another
file. Will add back if I need this later.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.cc (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:7: #include <string>
On 2013/04/23 18:26:48, Lei Zhang wrote:
> not used

Done.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:11: #include
"content/public/browser/web_contents.h"
On 2013/04/23 18:26:48, Lei Zhang wrote:
> not used

Done.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:15: #include
"ui/base/l10n/l10n_util.h"
On 2013/04/23 18:26:48, Lei Zhang wrote:
> not used

Done.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:16: #include
"ui/base/resource/resource_bundle.h"
On 2013/04/23 18:26:48, Lei Zhang wrote:
> not used

Done.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.cc:18: using
content::WebContents;
On 2013/04/23 18:26:48, Lei Zhang wrote:
> not used

Done.

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
File chrome/browser/ui/webui/sync_file_system_internals_ui.h (right):

https://codereview.chromium.org/14084008/diff/32001/chrome/browser/ui/webui/s...
chrome/browser/ui/webui/sync_file_system_internals_ui.h:13: virtual
~SyncFileSystemInternalsUI() {}
On 2013/04/23 18:26:48, Lei Zhang wrote:
> Please keep the implementation out of header files.

Done.

[calvinlo, 2013-04-25 08:47:41]

arv, sorry to bug you but is there anything else you want me to change in this
patch?

[calvinlo, 2013-04-26 06:09:52]

+dbeam. Hi Dan, arv seems busy or out of office. Is it possible for you to take
a look at the files here under chrome/browser/resources/ for OWNERS review.
Thanks

[calvinlo, 2013-04-30 05:18:21]

+estade for chrome/browser/resources/* OWNERS review. I'm hoping anyone from the
chrome/browser/resources/OWNERS file can be take a look at this patch for me.
It's really just boilerplate for me to start a new Sync File System Internals
Dashboard

[calvinlo, 2013-04-30 05:30:49]

Sorry, also OWNERS review for chrome/browser/ui/webui/ which happens to be the
same people as chrome/browser/resources/.

[arv (Not doing code reviews), 2013-04-30 20:26:06]

Where is the JS that drives the UI?

I assume you are planing to make the UI do something in a follow up patch so
LGTM for now

[calvinlo, 2013-05-01 02:21:38]

Thanks for reviewing arv. Yes, right now this patch does not do anything
functionally. I'm already working on adding the first bit of functionality in
another patch. 

I felt the boilerplate just to add the dashboard template added a sufficient
number of files and touched enough other files that I didn't want to both add
the boilerplate and functional code in the same patch.

[commit-bot: I haz the power, 2013-05-01 03:50:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/51001

[commit-bot: I haz the power, 2013-05-01 04:12:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 06:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/51001

[commit-bot: I haz the power, 2013-05-01 06:48:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 08:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/51001

[commit-bot: I haz the power, 2013-05-01 08:38:11]

Failed to apply patch for
chrome/browser/resources/sync_file_system_internals/main.css:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         chrome/browser/resources/sync_file_system_internals
  Created missing directory chrome/browser/resources/sync_file_system_internals.
  A         chrome/browser/resources/sync_file_system_internals/main.css
  Copied chrome/browser/resources/translate_internals/translate_internals.css ->
chrome/browser/resources/sync_file_system_internals/main.css
  patching file chrome/browser/resources/sync_file_system_internals/main.css
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/sync_file_system_internals/main.css.rej

Patch:   NR 
chrome/browser/resources/translate_internals/translate_internals.css->chrome/browser/resources/sync_file_system_internals/main.css
Index: chrome/browser/resources/sync_file_system_internals/main.css
diff --git
a/chrome/browser/resources/translate_internals/translate_internals.css
b/chrome/browser/resources/sync_file_system_internals/main.css
similarity index 55%
copy from chrome/browser/resources/translate_internals/translate_internals.css
copy to chrome/browser/resources/sync_file_system_internals/main.css
index
cfb2611b84487f5a653f57ac4bb1a0b465b76c57..6342e5a6cdcb98c7dfa242b35a563ddbd8ac46e5
100644
--- a/chrome/browser/resources/translate_internals/translate_internals.css
+++ b/chrome/browser/resources/sync_file_system_internals/main.css
@@ -2,8 +2,13 @@
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
-#tabpanel-prefs p {
-  font-family: monospace;
-  text-wrap: unrestricted;
-  white-space: pre-wrap;
+th,
+td {
+  padding-left: 0.5em;
+  padding-right: 0.5em;
+  text-align: center;
+}
+
+tr:nth-child(odd) {
+  background: rgb(238, 238, 255);
 }

[commit-bot: I haz the power, 2013-05-01 11:00:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/51001

[commit-bot: I haz the power, 2013-05-01 11:00:29]

Failed to apply patch for
chrome/browser/resources/sync_file_system_internals/main.css:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         chrome/browser/resources/sync_file_system_internals
  Created missing directory chrome/browser/resources/sync_file_system_internals.
  A         chrome/browser/resources/sync_file_system_internals/main.css
  Copied chrome/browser/resources/translate_internals/translate_internals.css ->
chrome/browser/resources/sync_file_system_internals/main.css
  patching file chrome/browser/resources/sync_file_system_internals/main.css
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/sync_file_system_internals/main.css.rej

Patch:   NR 
chrome/browser/resources/translate_internals/translate_internals.css->chrome/browser/resources/sync_file_system_internals/main.css
Index: chrome/browser/resources/sync_file_system_internals/main.css
diff --git
a/chrome/browser/resources/translate_internals/translate_internals.css
b/chrome/browser/resources/sync_file_system_internals/main.css
similarity index 55%
copy from chrome/browser/resources/translate_internals/translate_internals.css
copy to chrome/browser/resources/sync_file_system_internals/main.css
index
cfb2611b84487f5a653f57ac4bb1a0b465b76c57..6342e5a6cdcb98c7dfa242b35a563ddbd8ac46e5
100644
--- a/chrome/browser/resources/translate_internals/translate_internals.css
+++ b/chrome/browser/resources/sync_file_system_internals/main.css
@@ -2,8 +2,13 @@
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
-#tabpanel-prefs p {
-  font-family: monospace;
-  text-wrap: unrestricted;
-  white-space: pre-wrap;
+th,
+td {
+  padding-left: 0.5em;
+  padding-right: 0.5em;
+  text-align: center;
+}
+
+tr:nth-child(odd) {
+  background: rgb(238, 238, 255);
 }

[commit-bot: I haz the power, 2013-05-02 04:27:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/51001

[commit-bot: I haz the power, 2013-05-02 04:27:10]

Failed to apply patch for
chrome/browser/resources/sync_file_system_internals/main.css:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         chrome/browser/resources/sync_file_system_internals
  Created missing directory chrome/browser/resources/sync_file_system_internals.
  A         chrome/browser/resources/sync_file_system_internals/main.css
  Copied chrome/browser/resources/translate_internals/translate_internals.css ->
chrome/browser/resources/sync_file_system_internals/main.css
  patching file chrome/browser/resources/sync_file_system_internals/main.css
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/sync_file_system_internals/main.css.rej

Patch:   NR 
chrome/browser/resources/translate_internals/translate_internals.css->chrome/browser/resources/sync_file_system_internals/main.css
Index: chrome/browser/resources/sync_file_system_internals/main.css
diff --git
a/chrome/browser/resources/translate_internals/translate_internals.css
b/chrome/browser/resources/sync_file_system_internals/main.css
similarity index 55%
copy from chrome/browser/resources/translate_internals/translate_internals.css
copy to chrome/browser/resources/sync_file_system_internals/main.css
index
cfb2611b84487f5a653f57ac4bb1a0b465b76c57..6342e5a6cdcb98c7dfa242b35a563ddbd8ac46e5
100644
--- a/chrome/browser/resources/translate_internals/translate_internals.css
+++ b/chrome/browser/resources/sync_file_system_internals/main.css
@@ -2,8 +2,13 @@
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
-#tabpanel-prefs p {
-  font-family: monospace;
-  text-wrap: unrestricted;
-  white-space: pre-wrap;
+th,
+td {
+  padding-left: 0.5em;
+  padding-right: 0.5em;
+  text-align: center;
+}
+
+tr:nth-child(odd) {
+  background: rgb(238, 238, 255);
 }

[commit-bot: I haz the power, 2013-05-02 04:48:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14084008/78001

[commit-bot: I haz the power, 2013-05-02 06:43:41]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[calvinlo, 2013-05-02 07:13:28]

Committed patchset #7 manually as r197845 (presubmit successful).